GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104629: Build _testclinic extension module on Windows by erlend-aasland · Pull Request #104723 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Clinic test are skipped on Windows #104629

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-104629: Build _testclinic extension module on Windows
b0f5a4e
@erlend-aasland
erlend-aasland requested a review from a team as a code owner May 21, 2023 16:42
@erlend-aasland erlend-aasland added the skip news label May 21, 2023
@erlend-aasland
erlend-aasland requested review from zooba and zware May 21, 2023 16:42
@bedevere-bot bedevere-bot added the awaiting core review label May 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 21, 2023
Clinic test are skipped on Windows #104629
Closed
@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label May 21, 2023
@erlend-aasland

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
Contributor Author

DISCLAIMER: I don't have a Windows dev environment set up; I don't know anything about Visual Code (Visual Studio?). I have no idea if this works.

FYI, I used random GUID's.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented May 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I know nothing about the build system, but I can confirm that this builds fine on my Windows machine (building from the command line), and python -m test test_clinic -v still passes. The number of skipped tests goes from 51 to 0 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
Contributor Author

I know nothing about the build system, but I can confirm that this builds fine on my Windows machine (building from the command line), and python -m test test_clinic -v still passes. The number of skipped tests goes from 51 to 0 :)

Good to know! Thanks 😃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba
zooba reviewed May 22, 2023
View reviewed changes
Comment thread PCbuild/pcbuild.sln Outdated
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "_testcapi", "_testcapi.vcxproj", "{6901D91C-6E48-4BB7-9FEC-700C8131DF1D}"
EndProject
Project("{A840DDFB-ED50-484B-B527-B32E7CF90FD5}") = "_testclinic", "_testclinic.vcxproj", "{A840DDFB-ED50-484B-B527-B32E7CF90FD5}"

@zooba zooba May 22, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first guid should match the rest - it's the kind of the project, not the specific identifier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland May 30, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll update the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 355f339 look?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 355f339 look?

Let me try again: how does 355f339 and e9aa5a3 look?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread PCbuild/pcbuild.proj Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zware zware added the needs backport to 3.12 only security fixes label May 30, 2023
erlend-aasland and others added 5 commits June 2, 2023 13:58
@erlend-aasland
Pull in main
4f69c68
@erlend-aasland
Address review
355f339
@erlend-aasland
Fix 355f339
e9aa5a3
@erlend-aasland
Pull in main
d14de4b
@erlend-aasland
Add _testclinic to Tools/msi/test/test_files.wxs
a3e7085
@erlend-aasland
erlend-aasland requested a review from zooba July 17, 2023 20:53
@erlend-aasland

erlend-aasland commented Jul 27, 2023

Copy link
Copy Markdown
Contributor Author

@zooba or @zware: I totally forgot about this PR. With the current relatively high volume of clinic changes going on, I think it is important that we land this. Could one of you check if my last changes are ok?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware approved these changes Jul 28, 2023
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, and worked when I tried it. If there's anything we've missed, it can be cleaned up later :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji erlend-aasland reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 28, 2023
@erlend-aasland
erlend-aasland merged commit 3a1d819 into python:main Jul 28, 2023
@miss-islington

miss-islington commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 28, 2023
@miss-islington

miss-islington commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3a1d819ebc36189e086198212822c9b29384f242 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned erlend-aasland Jul 28, 2023
@bedevere-bot

bedevere-bot commented Jul 28, 2023

Copy link
Copy Markdown

GH-107393 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 28, 2023
@erlend-aasland
erlend-aasland deleted the clinic/windows-build branch July 28, 2023 16:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
@erlend-aasland @miss-islington
pythongh-104629: Build _testclinic extension module on Windows (pytho…
55a45d6 
…nGH-104723)

(cherry picked from commit 3a1d819)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 28, 2023
@miss-islington @erlend-aasland
[3.12] gh-104629: Build _testclinic extension module on Windows (GH-1…
b4355de 
…04723) (#107393)

(cherry picked from commit 3a1d819)

Co-authored-by: Erlend E. Aasland <[email protected]>
@zware zware removed the needs backport to 3.11 only security fixes label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @AlexWaygood @miss-islington @bedevere-bot @zooba @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.