GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89412: Add missing attributes (added in 3.10) to traceback module docs by Jackenmen · Pull Request #105046 · python/cpython

Conversation

@Jackenmen

@Jackenmen Jackenmen commented May 28, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It seems that end_lineno, and end_offset have been missed when the SyntaxError exception was modified in 3.10.

I reused the issue number of the original issue that added these attributes.

  • Issue: Update doctect SyntaxErrors for location range #89412

📚 Documentation preview 📚: https://cpython-previews--105046.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Jackenmen
pythongh-89412: Add missing 3.10 attributes to traceback module docs
6ef0700
@Jackenmen
Jackenmen requested a review from iritkatriel as a code owner May 28, 2023 21:06
@bedevere-bot bedevere-bot added the awaiting review label May 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 28, 2023
Update doctect SyntaxErrors for location range #89412
Closed
@Jackenmen Jackenmen mentioned this pull request May 28, 2023
GH-89455: Add missing attributes (added in 3.11) to traceback module docs #105044
Merged
@Jackenmen
Remove oxford comma
00a3eaa
@iritkatriel
iritkatriel requested a review from akulakov May 28, 2023 21:25
@iritkatriel iritkatriel added needs backport to 3.10 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes docs Documentation in the Doc dir labels May 28, 2023
@iritkatriel iritkatriel changed the title gh-89412: Add missing 3.10 attributes to traceback module docs gh-89412: Add missing attributes (added in 3.10) to traceback module docs May 29, 2023
@Jackenmen
Wrap at 80 chars and add a full stop
9ce5cc8
@akulakov

akulakov commented May 30, 2023

Copy link
Copy Markdown
Contributor

@pablogsal can you review as you've added these two attributes in #28575 ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv
ambv merged commit a4f72fa into python:main Jun 5, 2023
@miss-islington

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @Jackenmen for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting review label Jun 5, 2023
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105327 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
@Jackenmen @miss-islington
pythongh-89412: Add missing attributes (added in 3.10) to traceback m…
fd4875c
…odule docs (pythonGH-105046)

(cherry picked from commit a4f72fa)

Co-authored-by: Jakub Kuczys <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 5, 2023
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105328 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 5, 2023
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105329 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jun 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
@Jackenmen @miss-islington
pythongh-89412: Add missing attributes (added in 3.10) to traceback m…
077b26c
…odule docs (pythonGH-105046)

(cherry picked from commit a4f72fa)

Co-authored-by: Jakub Kuczys <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
@Jackenmen @miss-islington
pythongh-89412: Add missing attributes (added in 3.10) to traceback m…
cda57fd
…odule docs (pythonGH-105046)

(cherry picked from commit a4f72fa)

Co-authored-by: Jakub Kuczys <[email protected]>
ambv pushed a commit that referenced this pull request Jun 5, 2023
@miss-islington @Jackenmen
[3.12] gh-89412: Add missing attributes (added in 3.10) to traceback …
ab660e9
…module docs (GH-105046) (#105327)

(cherry picked from commit a4f72fa)

Co-authored-by: Jakub Kuczys <[email protected]>
ambv pushed a commit that referenced this pull request Jun 5, 2023
@miss-islington @Jackenmen
[3.11] gh-89412: Add missing attributes (added in 3.10) to traceback …
faae548
…module docs (GH-105046) (#105328)

(cherry picked from commit a4f72fa)

Co-authored-by: Jakub Kuczys <[email protected]>
ambv pushed a commit that referenced this pull request Jun 5, 2023
@miss-islington @Jackenmen
[3.10] gh-89412: Add missing attributes (added in 3.10) to traceback …
b7fd286
…module docs (GH-105046) (#105329)

(cherry picked from commit a4f72fa)

Co-authored-by: Jakub Kuczys <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.11 has failed when building commit faae548.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1006/builds/1010) and take a look at the build logs.
  4. Check if the failure is related to this commit (faae548) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1006/builds/1010

Failed tests:

  • test___all__

Failed subtests:

  • test_all - test.test___all__.AllTest.test_all

Summary of the results of the build (if available):

== Tests result: FAILURE then ENV CHANGED ==

419 tests OK.

10 slowest tests:

  • test_tools: 2 min 57 sec
  • test_concurrent_futures: 2 min 25 sec
  • test_multiprocessing_spawn: 2 min 3 sec
  • test_multiprocessing_fork: 1 min 30 sec
  • test_multiprocessing_forkserver: 1 min 15 sec
  • test_asyncio: 1 min 13 sec
  • test_tokenize: 51.2 sec
  • test_signal: 48.0 sec
  • test_capi: 41.4 sec
  • test_unparse: 40.1 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_launcher test_msilib
test_nis test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test___all__

Total duration: 5 min 22 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_689e16ea'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/test___all__.py", line 129, in test_all
    self.check_all(modname)
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/test___all__.py", line 43, in check_all
    with warnings_helper.check_warnings(
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/support/warnings_helper.py", line 185, in _filterwarnings
    raise AssertionError("unhandled warning %s" % reraise[0])
AssertionError: unhandled warning {message : DeprecationWarning("invalid escape sequence '\\?'"), category : 'DeprecationWarning', filename : '/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/test/test_httpservers.py', lineno : 445, line : None}


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_07ea7738'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-sles-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_2bd8fa86'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Jackenmen
Jackenmen deleted the traceback-docs-3.10-changes branch June 5, 2023 18:27
@gpshead

gpshead commented Jun 5, 2023

Copy link
Copy Markdown
Member

thanks for doing this!

Jackenmen reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@akulakov akulakov Awaiting requested review from akulakov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Jackenmen @akulakov @miss-islington @bedevere-bot @gpshead @ambv @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.