GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API by iritkatriel · Pull Request #105072 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented May 29, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I did not rename the internal function, but rather added an API function that calls it. This is because the internal function can make more assumptions about the input than an API function (so the API function raises exceptions on things that the internal function just asserts).

Fixes #105071.

CC @da-woods .

  • Issue: Add PyUnstable_Exc_PrepReraiseStar #105071

📚 Documentation preview 📚: https://cpython-previews--105072.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba and gpshead reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@iritkatriel
pythongh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except*…
5bc11a2 
… implementation in the unstable API
@iritkatriel
iritkatriel requested a review from encukou May 29, 2023 20:14
@bedevere-bot bedevere-bot added the awaiting core review label May 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Add PyUnstable_Exc_PrepReraiseStar #105071
Closed
@iritkatriel iritkatriel mentioned this pull request May 29, 2023
Expose _PyExc_PrepReraiseStar (and other intrinsics?) in the unstable api capi-workgroup/problems#40
Open
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc formatting nits. Otherwise: lgtm, as far as I can see.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/c-api/exceptions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/exceptions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/exceptions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel commented May 30, 2023
View reviewed changes
Comment thread Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel commented May 30, 2023
View reviewed changes
Comment thread Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 2 commits May 30, 2023 11:12
@iritkatriel @erlend-aasland
Apply suggestions from code review
b0a7b99 
Co-authored-by: Erlend E. Aasland <[email protected]>
@blurb-it
📜🤖 Added by blurb_it.
784b102
encukou
encukou approved these changes May 30, 2023
View reviewed changes

@encukou encukou left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2023
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 30, 2023
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 784b102 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 30, 2023
@iritkatriel
Merge branch 'main' into PyUnstable_Exc_PrepReraiseStar
95478a7
@iritkatriel iritkatriel added needs backport to 3.12 only security fixes topic-C-API interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed topic-C-API labels May 30, 2023
@iritkatriel
iritkatriel merged commit b7aadb4 into python:main May 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Sorry @iritkatriel, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker b7aadb4583b040ddc8564896b91f4e5e571c82d6 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned iritkatriel May 30, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request May 30, 2023
@iritkatriel
[3.12] pythongh-105071: add PyUnstable_Exc_PrepReraiseStar to expose …
28e968b 
…except* implementation in the unstable API (pythonGH-105072)

(cherry picked from commit b7aadb4)

Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel iritkatriel mentioned this pull request May 30, 2023
[3.12] gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API (GH-105072) #105095
Merged
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105095 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105095 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added a commit that referenced this pull request May 30, 2023
@iritkatriel
[3.12] gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except…
b45df73 
…* implementation in the unstable API (GH-105072) (#105095)

(cherry picked from commit b7aadb4)
@hugovk hugovk mentioned this pull request May 30, 2023
CI: Temporarily skip paths with spaces to avoid error #105110
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@iritkatriel
iritkatriel deleted the PyUnstable_Exc_PrepReraiseStar branch July 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iritkatriel iritkatriel

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add PyUnstable_Exc_PrepReraiseStar

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @bedevere-bot @miss-islington @encukou @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.