GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use CSV-separated outputs @ get-changed-files @ CI by webknjaz · Pull Request #105151 · python/cpython

Conversation

@webknjaz

@webknjaz webknjaz commented May 31, 2023

Copy link
Copy Markdown
Member

This is necessary because paths with whitespaces tend to crash said
action[1][2][3]. Also, we don't need to use JSON as it's harder
to parse while the value isn't used except for the emptiness check.

The change fixes [4]. It also reverts commit 4c77061.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
webknjaz added 2 commits May 31, 2023 17:43
@webknjaz
Revert "CI: Temporarily skip paths with spaces to avoid error (python…
4b0020f 
…#105110)"

This reverts commit 4c77061.
@webknjaz
Use CSV-separated outputs @ get-changed-files @ CI
9517c21 
This is necessary because paths with whitespaces tend to crash said
action[[1]][[2]][[3]]. Also, we don't need to use JSON as it's harder
to parse while the value isn't used except for the emptiness check.

The change fixes [[4]]

[1]: https://github.com/Ana06/get-changed-files#get-all-changed-files-as-space-delimited
[2]: python#103914 (comment)
[3]: python#103914 (comment)
[4]: python#103914 (comment)
@webknjaz
webknjaz requested review from ezio-melotti and hugovk as code owners May 31, 2023 16:00
@bedevere-bot bedevere-bot added the awaiting review label May 31, 2023
This was referenced May 31, 2023
Convert doc.yml workflow to be reusable #103914
Merged
[DNM] Empty changelog test for #105151 #105153
Closed
@webknjaz

webknjaz commented May 31, 2023

Copy link
Copy Markdown
Member Author

I've made a "demo PR" that should help verify that the fix is functional. It's here: #105153.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz

webknjaz commented May 31, 2023

Copy link
Copy Markdown
Member Author

I've made a "demo PR" that should help verify that the fix is functional. It's here: #105153.

UPD: it does work — https://github.com/python/cpython/actions/runs/5135145133/jobs/9240164159?pr=105153#step:5:17

cc @hugovk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz webknjaz mentioned this pull request May 31, 2023
CI: Temporarily skip paths with spaces to avoid error #105110
Merged
hugovk
hugovk reviewed May 31, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-docs.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Add --clean arg to take a list of comma-seperated files to touch
03e0e4c
@hugovk hugovk mentioned this pull request Jun 1, 2023
Add --clean arg to take a list of comma-seperated files to touch webknjaz/cpython#168
Merged
webknjaz
webknjaz commented Jun 4, 2023
View reviewed changes
Comment thread .github/workflows/reusable-docs.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
webknjaz and others added 4 commits June 4, 2023 22:59
@webknjaz
React to any "build changed files" command failure
1484c9f
@webknjaz
Quote touch-clean-files.py --clean argument
8fd85ab
@webknjaz
No-op fast with empty --clean passed for touch
f5a5220
@webknjaz @hugovk
Apply csv arg code comments by Hugo
5a9787b 
Co-authored-by: Hugo van Kemenade <[email protected]>
webknjaz
webknjaz commented Jun 4, 2023
View reviewed changes
Comment thread Doc/tools/touch-clean-files.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz
webknjaz requested a review from hugovk June 4, 2023 21:16
@webknjaz

webknjaz commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

@hugovk I think this needs skip issue and skip news too.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk added skip issue skip news labels Jun 5, 2023
hugovk
hugovk reviewed Jun 5, 2023
View reviewed changes
Comment thread Doc/tools/touch-clean-files.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/touch-clean-files.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-docs.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
webknjaz and others added 2 commits June 5, 2023 23:22
@webknjaz @hugovk
Refer to exit from sys explicitly
3e6f488 
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
Merge branch 'main' into maintenance/gha-reusable-docs-workflow--Ana0…
d19d319 
…6--get-changed-files--output-format
hugovk
hugovk approved these changes Jun 21, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 21, 2023
@hugovk
hugovk merged commit eaa6702 into python:main Jun 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 21, 2023
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 22, 2023
@webknjaz @hugovk
Use CSV-separated outputs @ get-changed-files @ CI (python#105151)
ee7a788 
Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit eaa6702)
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 22, 2023
@webknjaz @hugovk
Use CSV-separated outputs @ get-changed-files @ CI (python#105151)
aa38876 
Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit eaa6702)
This was referenced Jul 22, 2023
[3.12] Convert doc.yml workflow to be reusable (GH-103914 + GH-105151) #107042
Merged
[3.11] Convert doc.yml workflow to be reusable (GH-103914 + GH-105151) #107043
Merged
ambv pushed a commit that referenced this pull request Jul 23, 2023
@webknjaz
[3.11] Convert doc.yml workflow to be reusable (GH-103914 + GH-105151…
561029a 
…) (#107043)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>.

(cherry picked from commit 88d14da)
(cherry picked from commit eaa6702)
ambv pushed a commit that referenced this pull request Jul 23, 2023
@webknjaz
[3.12] Convert doc.yml workflow to be reusable (GH-103914 + GH-105151…
1703262 
…) (#107042)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>

(cherry picked from commit 88d14da)
(cherry picked from commit eaa6702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@webknjaz @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.