GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105286: Further improvements to `typing.py` docstrings by AlexWaygood · Pull Request #105363 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jun 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A small followup PR to #105287

  • Issue: Improve typing.py docstrings #105286

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-105286: Further improvements to typing.py docstrings
aa90be8
@AlexWaygood AlexWaygood added skip news topic-typing needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 6, 2023
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners June 6, 2023 10:34
@bedevere-bot bedevere-bot added the awaiting core review label Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Improve typing.py docstrings #105286
Closed
@JelleZijlstra
JelleZijlstra merged commit 9a89f1b into python:main Jun 7, 2023
@miss-islington

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 7, 2023
@miss-islington

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AlexWaygood and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9a89f1bf1e7bb819fe7240be779c99a84f47ea46 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @miss-islington
pythongh-105286: Further improvements to typing.py docstrings (pyth…
cedc709 
…onGH-105363)

(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <[email protected]>
@miss-islington miss-islington assigned JelleZijlstra Jun 7, 2023
@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105416 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @JelleZijlstra
[3.11] pythongh-105286: Further improvements to typing.py docstrings (
07a6713 
pythonGH-105363).

(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105417 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 7, 2023
JelleZijlstra pushed a commit that referenced this pull request Jun 7, 2023
@miss-islington @AlexWaygood
[3.12] gh-105286: Further improvements to typing.py docstrings (GH-…
84133c5 
…105363) (#105416)

gh-105286: Further improvements to `typing.py` docstrings (GH-105363)
(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <[email protected]>
@AlexWaygood
AlexWaygood deleted the more-docstring-improvements branch June 7, 2023 06:39
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@JelleZijlstra @AlexWaygood
[3.11] gh-105286: Further improvements to typing.py docstrings (GH-…
3a195f3 
…105363) (#105417)

[3.11] gh-105286: Further improvements to `typing.py` docstrings (GH-105363).
(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.