GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105390: Add explicit type cast by Eclips4 · Pull Request #105466 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jun 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Somehow it showed up in #105443
Also, I'm not sure that this is the correct solution.
But, seems that there need a explicit convertion

  • Issue: (3.12+) tokenize exception type is wrong #105390

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4
add explicit convertion
ed74f61
@bedevere-bot bedevere-bot added the awaiting review label Jun 7, 2023
@Eclips4

Eclips4 commented Jun 7, 2023

Copy link
Copy Markdown
Member Author

Seems to be introduced in #105399
cc @pablogsal

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4 Eclips4 changed the title Fix ci/cd warning Add explicit type cast Jun 7, 2023
@arhadthedev arhadthedev changed the title Add explicit type cast gh-105390: Fix ci/cd warning Jun 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 7, 2023
(3.12+) tokenize exception type is wrong #105390
Closed
@arhadthedev arhadthedev changed the title gh-105390: Fix ci/cd warning gh-105390: Add explicit type cast Jun 7, 2023
@pablogsal pablogsal added the skip news label Jun 7, 2023
pablogsal
pablogsal approved these changes Jun 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 7, 2023
@pablogsal
pablogsal enabled auto-merge (squash) June 7, 2023 20:20
@pablogsal
pablogsal merged commit 264a011 into python:main Jun 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 7, 2023
@Eclips4

Eclips4 commented Jun 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@pablogsal #105399 was backported to 3.12 branch, so, I think this PR also should be backported.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 264a011.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/4158) and take a look at the build logs.
  4. Check if the failure is related to this commit (264a011) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/4158

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

427 tests OK.

10 slowest tests:

  • test_venv: 10 min 3 sec
  • test_mailbox: 8 min 45 sec
  • test_largefile: 8 min 32 sec
  • test_shelve: 5 min 17 sec
  • test_math: 4 min 31 sec
  • test_multiprocessing_spawn: 4 min 13 sec
  • test_gdb: 3 min 44 sec
  • test_concurrent_futures: 3 min 32 sec
  • test_embed: 2 min 19 sec
  • test_peg_generator: 2 min 15 sec

1 test altered the execution environment:
test_concurrent_futures

19 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_perf_profiler
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 38 min 22 sec

Click to see traceback logs
remote: Enumerating objects: 7, done.        
remote: Counting objects:  14% (1/7)        
remote: Counting objects:  28% (2/7)        
remote: Counting objects:  42% (3/7)        
remote: Counting objects:  57% (4/7)        
remote: Counting objects:  71% (5/7)        
remote: Counting objects:  85% (6/7)        
remote: Counting objects: 100% (7/7)        
remote: Counting objects: 100% (7/7), done.        
remote: Compressing objects:  50% (1/2)        
remote: Compressing objects: 100% (2/2)        
remote: Compressing objects: 100% (2/2), done.        
remote: Total 4 (delta 3), reused 2 (delta 2), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '264a0110ffa4e08b0c7b1023e67a6bd7cb9617c6'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 264a0110ff gh-105390: Add explicit type cast (#105466)
Switched to and reset branch 'main'

./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:62:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   62 |                            (unsigned long long)data_ptr,
      |                            ^

make: *** [Makefile:2003: buildbottest] Error 3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal added the needs backport to 3.12 only security fixes label Jun 7, 2023
@miss-islington

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105472 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@Eclips4 @miss-islington
pythongh-105390: Add explicit type cast (pythonGH-105466)
9826fac
(cherry picked from commit 264a011)

Co-authored-by: Kirill Podoprigora <[email protected]>
pablogsal pushed a commit that referenced this pull request Jun 7, 2023
@miss-islington
[3.12] gh-105390: Add explicit type cast (GH-105466) (#105472)
3d4a786
@Eclips4
Eclips4 deleted the fix_cicd branch June 8, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Eclips4 @bedevere-bot @miss-islington @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.