GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105433: Add `pickle` tests for PEP695 by sobolevn · Pull Request #105443 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've tried to cover all cases:

  • type aliases (including recursive ones)
  • functions
  • classes

And different param types:

  • regular typevars
  • bound typevars
  • constrained typevars
  • typevartuples
  • paramspecs

Anything that I am missing?

  • Issue: PEP 695 is not tested to be pickleable #105433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-105433: Add pickle tests for PEP695
9e99313
@sobolevn
sobolevn requested a review from JelleZijlstra as a code owner June 7, 2023 11:45
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 7, 2023
PEP 695 is not tested to be pickleable #105433
Closed
@sobolevn
Fix lint
66345c2
@sobolevn sobolevn added the skip news label Jun 7, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Jun 7, 2023
JelleZijlstra
JelleZijlstra reviewed Jun 7, 2023
View reviewed changes
Comment thread Lib/test/test_type_params.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Also test instances
0453391
JelleZijlstra
JelleZijlstra approved these changes Jun 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 7, 2023
@Eclips4 Eclips4 mentioned this pull request Jun 7, 2023
gh-105390: Add explicit type cast #105466
Merged
@JelleZijlstra
JelleZijlstra merged commit 1af8251 into python:main Jun 16, 2023
@miss-islington

miss-islington commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2023
@sobolevn @miss-islington
pythongh-105433: Add pickle tests for PEP695 (pythonGH-105443)
6d82bd9 
(cherry picked from commit 1af8251)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 16, 2023

Copy link
Copy Markdown

GH-105845 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 16, 2023
JelleZijlstra pushed a commit that referenced this pull request Jun 16, 2023
@miss-islington @sobolevn
[3.12] gh-105433: Add pickle tests for PEP695 (GH-105443) (#105845)
0cb670f 
(cherry picked from commit 1af8251)

Co-authored-by: Nikita Sobolev <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jun 16, 2023
@carljm
Merge branch 'main' into modulelocals
b096651 
* main:
  pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846)
  pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835)
  CI: Remove docs build from Azure Pipelines (python#105823)
  pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851)
  Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969)
  pythongh-105433: Add `pickle` tests for PEP695 (python#105443)
  bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189)
  pythonGH-103124: Multiline statement support for pdb (pythonGH-103125)
  pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 18, 2023
@sobolevn @gvanrossum
pythongh-105433: Add pickle tests for PEP695 (python#105443)
9a75ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.