GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105375: Improve error handling in the sys extension module by erlend-aasland · Pull Request #105611 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Bail on first error to prevent exceptions from possibly being
overwritten.

  • Issue: Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-105375: Improve error handling in the sys extension module
02cac21 
Bail on first error to prevent exceptions from possibly being
overwritten.
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks done
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 11, 2023
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 02cac21 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 11, 2023
@erlend-aasland
erlend-aasland requested a review from sobolevn June 11, 2023 10:41
@erlend-aasland
Merge branch 'main' into improve-sysmodule-error-handling
56280c5
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 11, 2023 19:38
@erlend-aasland
erlend-aasland disabled auto-merge June 11, 2023 19:38
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 11, 2023 19:39
@erlend-aasland
erlend-aasland merged commit 41cddc2 into python:main Jun 11, 2023
@miss-islington

miss-islington commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 11, 2023
@miss-islington

miss-islington commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 41cddc2e93a285b81fa30ac542b088bd9d0112e9 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned erlend-aasland Jun 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in the sys extension module (p…
753d979 
…ythonGH-105611)

In _PySys_AddXOptionWithError() and sys_add_xoption(),
bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 41cddc2)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

GH-105665 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
@erlend-aasland
erlend-aasland deleted the improve-sysmodule-error-handling branch June 11, 2023 20:05
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland
[3.11] pythongh-105375: Improve error handling in the sys extension m…
3d5eb67 
…odule (python#105611)

(cherry picked from commit 41cddc2)

In _PySys_AddXOptionWithError() and sys_add_xoption(),
bail on first error to prevent exceptions from possibly being
overwritten.

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

GH-105666 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@erlend-aasland
[3.11] gh-105375: Improve error handling in the sys extension module (#…
f98d475 
…105611) (#105666)

(cherry picked from commit 41cddc2)

In _PySys_AddXOptionWithError() and sys_add_xoption(),
bail on first error to prevent exceptions from possibly being
overwritten.
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve error handling in the sys extension module (G…
a1034b5 
…H-105611) (#105665)

In _PySys_AddXOptionWithError() and sys_add_xoption(),
bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 41cddc2)

Co-authored-by: Erlend E. Aasland <[email protected]>
serhiy-storchaka
serhiy-storchaka reviewed Jun 12, 2023
View reviewed changes
Comment thread Python/sysmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/sysmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn sobolevn mentioned this pull request Jun 12, 2023
gh-105673: Fix uninitialized warning in sysmodule.c #105674
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@sobolevn sobolevn Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @miss-islington @serhiy-storchaka @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.