GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105673: Fix uninitialized warning in sysmodule.c by sobolevn · Pull Request #105674 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The simplest possible solution.
Refs #105611

  • Issue: New warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] #105673

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-105673: Fix `‘value’ may be used uninitialized in this funct…
5ec5d84 
…ion` warning in `sysmodule.c`
@sobolevn
sobolevn requested a review from erlend-aasland June 12, 2023 08:20
@bedevere-bot bedevere-bot added the awaiting review label Jun 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 12, 2023
New warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] #105673
Closed
@sobolevn sobolevn added the skip news label Jun 12, 2023
erlend-aasland
erlend-aasland approved these changes Jun 12, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 12, 2023
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 12, 2023
@erlend-aasland erlend-aasland changed the title gh-105673: Fix ‘value’ may be used uninitialized in this function warning in sysmodule.c gh-105673: Fix uninitialized warning in sysmodule.c Jun 12, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 12, 2023 08:24
@erlend-aasland
erlend-aasland merged commit a8d69fe into python:main Jun 12, 2023
@miss-islington

miss-islington commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 12, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2023
@sobolevn @miss-islington
pythongh-105673: Fix uninitialized warning in sysmodule.c (pythonGH-1…
ef32a01 
…05674)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 12, 2023

Copy link
Copy Markdown

GH-105675 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 12, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2023
@sobolevn @miss-islington
pythongh-105673: Fix uninitialized warning in sysmodule.c (pythonGH-1…
8cc1851 
…05674)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 12, 2023

Copy link
Copy Markdown

GH-105676 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 12, 2023
erlend-aasland pushed a commit that referenced this pull request Jun 12, 2023
@miss-islington @sobolevn
[3.11] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (
171aa08 
#105676)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <[email protected]>
erlend-aasland pushed a commit that referenced this pull request Jun 12, 2023
@miss-islington @sobolevn
[3.12] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (
0b305e8 
#105675)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @miss-islington @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.