GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-105708: 'V' could be case insensitive for IPvFuture hostnames by csreddy98 · Pull Request #105709 · python/cpython

Conversation

csreddy98 commented Jun 12, 2023

Copy link

Copy Markdown

Contributor

As per the standards the 'v' could be case-insensitive as mentioned here.

issue: GH-105708

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added the awaiting review label

Jun 12, 2023

bedevere-bot commented Jun 12, 2023

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot mentioned this pull request

Jun 12, 2023

urlparser does not allow 'V' in the IPvFuture. #105708

Closed

ghost commented Jun 12, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev commented Jun 13, 2023

Copy link

Copy Markdown

Member

@orsenthil (as an urllib expert)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Apr 13, 2026

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Apr 13, 2026

orsenthil force-pushed the IPvFuture-v-is-case-insensitive branch from 6b0e9ab to fb1de1a Compare

July 5, 2026 12:12

orsenthil reviewed

Jul 5, 2026

View reviewed changes

Comment thread

Lib/urllib/parse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

orsenthil requested a review from serhiy-storchaka

July 5, 2026 14:14

orsenthil reviewed

Jul 5, 2026

View reviewed changes

Comment thread

Lib/test/test_urlparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

orsenthil removed the stale Stale PR or inactive for long period of time. label

Jul 5, 2026

serhiy-storchaka approved these changes

Jul 5, 2026

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Misc/NEWS.d/next/Library/2023-06-12-21-31-02.gh-issue-105708.5fFwP8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jul 5, 2026

csreddy98 and others added 5 commits

July 5, 2026 09:02


          pythongh-105708: 'V' could be case insensitive for IPvFuture hostnames

d140752


          pythongh-105708: 'V' could be case insensitive for IPvFuture hostname…

529ee95

…s & checking empty hostnames


          📜🤖 Added by blurb_it.

d6e7564


          Fix the Merge changing \z to \Z.

27f5102


          Fixed the News Entry.

d90aa84

orsenthil force-pushed the IPvFuture-v-is-case-insensitive branch from 7593d8a to d90aa84 Compare

July 5, 2026 16:03


          Fix the lint.

7d47bab

orsenthil added needs backport to 3.13

only security fixes

needs backport to 3.14

bugs and security fixes

needs backport to 3.15 bugs and security fixes labels

Jul 5, 2026

orsenthil merged commit a47a66c into python:main

Jul 5, 2026

57 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jul 5, 2026

Copy link

Copy Markdown

Thanks @csreddy98 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jul 5, 2026

bedevere-app Bot commented Jul 5, 2026

Copy link

Copy Markdown

GH-153138 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Jul 5, 2026

miss-islington-app Bot commented Jul 5, 2026

Copy link

Copy Markdown

Sorry, @csreddy98 and @orsenthil, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a47a66ccef0f98fcf088bc260ca14b889efa9b04 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned orsenthil

Jul 5, 2026

bedevere-app Bot commented Jul 5, 2026

Copy link

Copy Markdown

GH-153139 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jul 5, 2026

orsenthil added a commit that referenced this pull request

Jul 5, 2026


          [3.15] gh-105708: 'V' could be case insensitive for IPvFuture hostnam…

986322e

…es (GH-105709) (#153138)

gh-105708: 'V' could be case insensitive for IPvFuture hostnames (GH-105709)

* gh-105708: 'V' could be case insensitive for IPvFuture hostnames

* gh-105708: 'V' could be case insensitive for IPvFuture hostnames & checking empty hostnames

* 📜🤖 Added by blurb_it.

* Fix the Merge changing \z to \Z.

* Fixed the News Entry.

* Fix the lint.

---------
(cherry picked from commit a47a66c)

Co-authored-by: Chandra <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <[email protected]>

orsenthil added a commit that referenced this pull request

Jul 5, 2026


          [3.14] gh-105708: 'V' could be case insensitive for IPvFuture hostnam…

85c58cf

…es (GH-105709) (#153139)

gh-105708: 'V' could be case insensitive for IPvFuture hostnames (GH-105709)

* gh-105708: 'V' could be case insensitive for IPvFuture hostnames

* gh-105708: 'V' could be case insensitive for IPvFuture hostnames & checking empty hostnames

* 📜🤖 Added by blurb_it.

* Fix the Merge changing \z to \Z.

* Fixed the News Entry.

* Fix the lint.

---------
(cherry picked from commit a47a66c)

Co-authored-by: Chandra <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <[email protected]>

orsenthil commented Jul 5, 2026

Copy link

Copy Markdown

Member

I could not cleanly backport this to 3.13 due to a conflict.

Manually created here #153140

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

orsenthil added a commit that referenced this pull request

Jul 5, 2026


          [3.13] gh-105708: 'V' could be case insensitive for IPvFuture hostnam…

491d830

…es (#5709) (#153140)

gh-105708: 'V' could be case insensitive for IPvFuture hostnames (#105709)

* gh-105708: 'V' could be case insensitive for IPvFuture hostnames

* gh-105708: 'V' could be case insensitive for IPvFuture hostnames & checking empty hostnames

* 📜🤖 Added by blurb_it.

* Fix the Merge changing \z to \Z.

* Fixed the News Entry.

* Fix the lint.

---------



(cherry picked from commit a47a66c)

Co-authored-by: Chandra <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

StanFromIreland removed the needs backport to 3.13 only security fixes label

Jul 6, 2026

Reviewers

orsenthil

orsenthil left review comments

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

orsenthil

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

csreddy98 commented Jun 12, 2023

Uh oh!

bedevere-bot commented Jun 12, 2023

Uh oh!

ghost commented Jun 12, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arhadthedev commented Jun 13, 2023

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Jul 5, 2026

Uh oh!

bedevere-app Bot commented Jul 5, 2026

Uh oh!

miss-islington-app Bot commented Jul 5, 2026

Uh oh!

bedevere-app Bot commented Jul 5, 2026

Uh oh!

orsenthil commented Jul 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ghost commented Jun 12, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.