GeezerVison

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All commit authors signed the Contributor License Agreement.

Duplicate of #105984
@kr-g already working on this issue, so, please, close this PR.
You can pick-up another issue, there's a lot of them =)

@Eclips4
Well, what's the problem? I also tried to add this feature.

good day @AmirNakhaeii,

just received your message via email.
and saw the message from @Eclips4

when you would please have a look at the history of the initial pull request #105984 and the code given there you will see that i already did the development before i have created the issue #105983 regarding the new feature. it is a bit confusing sometimes how github organize the flow of information.

anyway i saw that you added also support for edge.

thats great because i dont have microsoft windows.
i do development on linux only.
thank you.

probably best would be that you wait until my pull request is merged, and then you create an own issue regarding the enhancement and support for edge. and an extra pull request for that.

myself would prefer this approach since i can not spent time for taking part in a development where i dont have the proper OS and can not even test it.

thanks for your contribution, and understanding.

ps. do close your pull request #106069, also because you followed the naming convention and gave it the same name as mine - thats might be confusing to others -

just corrected the different pull requests numbers in my former reply. sorry for the confusion.

@AmirNakhaeii

probably best would be that you wait until my pull request is merged, and then you create an own issue regarding the enhancement and support for edge. and an extra pull request for that.

i dont know if it is possible to create "depening" issues in github.

but probably it might be also an idea to clone my git repo and checkout the branch https://github.com/kr-g/cpython/tree/kr-g-browser-incognito and create from this HEAD ref a new branch where you put your code for edge browser.

@AmirNakhaeii

please have also a look here https://github.com/python/cpython/pull/105984/files at the test cases -> Lib/test/test_webbrowser.py

you need to create also one for Edge.
Thanks

@kr-g
Thank you for your guidance. I will definitely fulfill your request. Good luck.

@kr-g
I rarely visit my Gmail. That's why I didn't see your message.

@AmirNakhaeii

I rarely visit my Gmail. That's why I didn't see your message.

ok fine, i try to keep that in mind