GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Harden Argument Clinic parser tests by erlend-aasland · Pull Request #106384 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Also assert parser error messages.

  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-106368: Harden Argument Clinic parser tests
e676d61 
Also assert parser error messages.
@erlend-aasland erlend-aasland added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 3, 2023
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 3, 2023
Increase Argument Clinic test coverage #106368
Closed
@erlend-aasland
naming
2414e65
@erlend-aasland

erlend-aasland commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

I consider this uncontroversial; will merge when CI is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 3, 2023 22:39
@erlend-aasland erlend-aasland added skip issue and removed skip issue labels Jul 3, 2023
@erlend-aasland
erlend-aasland merged commit 648688c into python:main Jul 3, 2023
@miss-islington

miss-islington commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 3, 2023
@erlend-aasland
erlend-aasland deleted the clinic/assert-error-messages branch July 3, 2023 23:10
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
@erlend-aasland @miss-islington
pythongh-106368: Harden Argument Clinic parser tests (pythonGH-106384)
f384c75 
(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 3, 2023

Copy link
Copy Markdown

GH-106387 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
@erlend-aasland @miss-islington
pythongh-106368: Harden Argument Clinic parser tests (pythonGH-106384)
144c836 
(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 3, 2023
@bedevere-bot

bedevere-bot commented Jul 3, 2023

Copy link
Copy Markdown

GH-106388 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 3, 2023
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
@miss-islington @erlend-aasland
[3.11] gh-106368: Harden Argument Clinic parser tests (GH-106384) (#1…
7688964 
…06388)

(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Harden Argument Clinic parser tests (GH-106384) (#1…
6720003 
…06387)

(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Jul 4, 2023
@carljm
Merge branch 'main' into cachedpropdoublecheck
7a7fd43 
* main:
  pythongh-106368: Increase Argument Clinic test coverage (python#106389)
  pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386)
  pythongh-106368: Harden Argument Clinic parser tests (python#106384)
  pythongh-106320: Remove private _PyImport C API functions (python#106383)
  pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377)
  pythongh-106320: Remove more private _PyUnicode C API functions (python#106382)
  pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376)
  pythongh-106368: Clean up Argument Clinic tests (python#106373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.