GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-106368: Increase Argument Clinic test coverage by erlend-aasland · Pull Request #106389 · python/cpython

Conversation

erlend-aasland commented Jul 3, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Add:

test_disallowed_gropuing__no_matching_bracket
test_double_slash

Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-106368: Increase Argument Clinic test coverage

2e2b42f

Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash

erlend-aasland added skip news needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jul 3, 2023

bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels

Jul 3, 2023

bedevere-bot mentioned this pull request

Jul 3, 2023

Increase Argument Clinic test coverage #106368

Closed

erlend-aasland enabled auto-merge (squash)

July 3, 2023 23:19

AlexWaygood reviewed

Jul 3, 2023

View reviewed changes

Comment thread

Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Lib/test/test_clinic.py

90597cb

Co-authored-by: Alex Waygood <[email protected]>

erlend-aasland merged commit 3406f8c into python:main

Jul 3, 2023

bedevere-bot removed the awaiting core review label

Jul 3, 2023

miss-islington commented Jul 3, 2023

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 3, 2023


          pythongh-106368: Increase Argument Clinic test coverage (pythonGH-106389

af012ad

)

Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash
(cherry picked from commit 3406f8c)

Co-authored-by: Erlend E. Aasland <[email protected]>

bedevere-bot commented Jul 3, 2023

Copy link

Copy Markdown

GH-106390 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 3, 2023


          pythongh-106368: Increase Argument Clinic test coverage (pythonGH-106389

c7b2d87

)

Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash
(cherry picked from commit 3406f8c)

Co-authored-by: Erlend E. Aasland <[email protected]>

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 3, 2023

bedevere-bot commented Jul 3, 2023

Copy link

Copy Markdown

GH-106391 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 3, 2023

erlend-aasland deleted the clinic/add-tests branch

July 4, 2023 00:11

erlend-aasland added a commit that referenced this pull request

Jul 4, 2023


          [3.11] gh-106368: Increase Argument Clinic test coverage (GH-106389) (#…

3cc5c4a

…106391)

Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash
(cherry picked from commit 3406f8c)

Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland added a commit that referenced this pull request

Jul 4, 2023


          [3.12] gh-106368: Increase Argument Clinic test coverage (GH-106389) (#…

b84365f

…106390)

Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash
(cherry picked from commit 3406f8c)

Co-authored-by: Erlend E. Aasland <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Jul 4, 2023


          Merge branch 'main' into cachedpropdoublecheck

7a7fd43

* main:
  pythongh-106368: Increase Argument Clinic test coverage (python#106389)
  pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386)
  pythongh-106368: Harden Argument Clinic parser tests (python#106384)
  pythongh-106320: Remove private _PyImport C API functions (python#106383)
  pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377)
  pythongh-106320: Remove more private _PyUnicode C API functions (python#106382)
  pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376)
  pythongh-106368: Clean up Argument Clinic tests (python#106373)

Reviewers

AlexWaygood

AlexWaygood left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jul 3, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Jul 3, 2023

Uh oh!

bedevere-bot commented Jul 3, 2023

Uh oh!

bedevere-bot commented Jul 3, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Jul 3, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.