GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Partially annotate Argument Clinic CLanguage class by erlend-aasland · Pull Request #106437 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Saving render_option_group_parsing() and output_templates() methods for later

  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
erlend-aasland added 5 commits July 5, 2023 00:13
@erlend-aasland
Annotate parse_line()
4c84c3b
@erlend-aasland
Partially annotate render()
f5b6f19
@erlend-aasland
Annotate docstring_for_c_string()
cd16164
@erlend-aasland
Annotate group_to_variable_name()
3100fee
@erlend-aasland
Annotate render_function()
69d2a60
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 4, 2023 22:19
@erlend-aasland erlend-aasland added the skip news label Jul 4, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 4, 2023
Add type annotations to clinic.py #104050
Closed
AlexWaygood
AlexWaygood approved these changes Jul 4, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 4, 2023
erlend-aasland and others added 2 commits July 5, 2023 00:40
@erlend-aasland
Pull in main
2f44485
@AlexWaygood @erlend-aasland
Address review
68668b2
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 4, 2023 22:41
@erlend-aasland
erlend-aasland merged commit 7bb9fa5 into python:main Jul 4, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 4, 2023
@bedevere-bot

bedevere-bot commented Jul 5, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.x has failed when building commit 7bb9fa5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/366/builds/4739) and take a look at the build logs.
  4. Check if the failure is related to this commit (7bb9fa5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/366/builds/4739

Failed tests:

  • test_unittest

Failed subtests:

  • test_wait_until_any_call_with_positional - test.test_unittest.testmock.testthreadingmock.TestThreadingMock.test_wait_until_any_call_with_positional

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

423 tests OK.

10 slowest tests:

  • test_math: 5 min 10 sec
  • test_multiprocessing_spawn: 4 min
  • test_signal: 3 min 52 sec
  • test_concurrent_futures: 3 min 5 sec
  • test_multiprocessing_forkserver: 2 min 10 sec
  • test_capi: 1 min 49 sec
  • test_tokenize: 1 min 49 sec
  • test_unparse: 1 min 32 sec
  • test_tarfile: 1 min 20 sec
  • test_unicodedata: 1 min 20 sec

1 test failed:
test_unittest

22 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_epoll
test_gdb test_idle test_ioctl test_launcher
test_multiprocessing_fork test_perf_profiler test_perfmaps
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test_unittest

Total duration: 29 min 59 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_unittest/testmock/testthreadingmock.py", line 177, in test_wait_until_any_call_with_positional
    self.assertIn(call(2), something.method_1.mock_calls)
AssertionError: call(2) not found in [call(1), call(3)]


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_unittest/testmock/testthreadingmock.py", line 173, in test_wait_until_any_call_with_positional
    self.assertNotIn(call(2), something.method_1.mock_calls)
AssertionError: call(2) unexpectedly found in [call(2), call(1)]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland deleted the clinic/annotate-clanguage branch July 5, 2023 06:58
carljm added a commit to carljm/cpython that referenced this pull request Jul 5, 2023
@carljm
Merge branch 'main' into modulelocals
4c59e51
* main: (39 commits)
  pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)
  Clarify state of CancelledError in doc (python#106453)
  pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)
  pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)
  tp_flags docs: fix indentation (python#106420)
  pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)
  pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)
  pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)
  pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)
  pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)
  Add some codeowners for `Tools/clinic/` (python#106430)
  pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)
  pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)
  pythongh-106162: array: suppress warning in test_array (python#106404)
  pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)
  pythonGH-106360: Support very basic superblock introspection (python#106422)
  pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)
  pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)
  pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)
  pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.