GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-64595: Fix regression in file write logic in Argument Clinic (#106449) by erlend-aasland · Pull Request #106452 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Revert the two commits that introduced the regressions:

  • gh-64595: Argument Clinic: Touch source file if any output file changed #104152
  • gh-64595: Fix write file logic in Argument Clinic #104507

(cherry picked from commit 9d1d4f9)

Co-authored-by: Erlend Aasland [email protected]

  • Issue: Argument Clinic: Touch source file if any output file changed #64595

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
[3.12] pythongh-64595: Fix regression in file write logic in Argument…
b02430a 
… Clinic (python#106449)

Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507

(cherry picked from commit 9d1d4f9)

Co-authored-by: Erlend Aasland <[email protected]>
@erlend-aasland erlend-aasland added the skip news label Jul 5, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 5, 2023
This was referenced Jul 5, 2023
Argument Clinic: Touch source file if any output file changed #64595
Closed
gh-64595: Fix regression in file write logic in Argument Clinic #106449
Merged
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 5, 2023 12:45
@erlend-aasland
erlend-aasland merged commit b72601e into python:3.12 Jul 5, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 5, 2023
@erlend-aasland
erlend-aasland deleted the backport-3.12-revert-clinic branch August 31, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.