GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-64595: Fix write file logic in Argument Clinic by erlend-aasland · Pull Request #104507 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Check if any clinic output actually changes any of the output files
before deciding if we should touch the source file. This needs to be
done before we eventually update the source file.

  • Issue: Argument Clinic: Touch source file if any output file changed #64595

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-64595: Fix write file logic in Argument Clinic
15bf463
Check if any clinic output actually changes any of the output files
before deciding if we should touch the source file. This needs to be
done before we eventually update the source file.
@erlend-aasland erlend-aasland added the skip news label May 15, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2023
Argument Clinic: Touch source file if any output file changed #64595
Closed
@erlend-aasland
erlend-aasland requested a review from hauntsaninja May 15, 2023 13:03
@erlend-aasland
Alternative implementation
2a20f90
@erlend-aasland

erlend-aasland commented May 15, 2023

Copy link
Copy Markdown
Contributor Author

Alternative implementation (my preference) in 2a20f90.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland merged commit cca90b6 into python:main May 16, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 16, 2023
@erlend-aasland
erlend-aasland deleted the clinic-dont-touch-everything branch May 16, 2023 10:25
carljm added a commit to carljm/cpython that referenced this pull request May 16, 2023
@carljm
Merge branch 'main' into supermon
a6dd626
* main:
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  pythongh-64595: Fix write file logic in Argument Clinic (python#104507)
  pythongh-104523: Inline minimal PGO rules (python#104524)
  pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)
  pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)
  pythongh-103763: Implement PEP 695 (python#103764)
  pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)
  pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)
  pythongh-104482: Fix error handling bugs in ast.c (python#104483)
  pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)
  pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
@erlend-aasland erlend-aasland mentioned this pull request Jul 5, 2023
gh-64595: Fix regression in file write logic in Argument Clinic #106449
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 5, 2023
@erlend-aasland
pythongh-64595: Fix regression in file write logic in Argument Clinic
6f5936a
Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507
ambv pushed a commit that referenced this pull request Jul 5, 2023
@erlend-aasland
gh-64595: Fix regression in file write logic in Argument Clinic (#106449
9d1d4f9
)

Revert the two commits that introduced the regressions:

 - gh-104152
 - gh-104507
@erlend-aasland erlend-aasland mentioned this pull request Jul 5, 2023
[3.12] gh-64595: Fix regression in file write logic in Argument Clinic (#106449) #106452
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 5, 2023
@erlend-aasland
[3.12] pythongh-64595: Fix regression in file write logic in Argument…
b02430a
… Clinic (python#106449)

Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507

(cherry picked from commit 9d1d4f9)

Co-authored-by: Erlend Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 5, 2023
@erlend-aasland
[3.12] gh-64595: Fix regression in file write logic in Argument Clinic (
b72601e
#106449) (#106452)

Revert the two commits that introduced the regressions:

 - gh-104152
 - gh-104507

(cherry picked from commit 9d1d4f9)
@erlend-aasland

erlend-aasland commented Jan 12, 2024

Copy link
Copy Markdown
Contributor Author

I'm going to do some more yak-shaving (#113317) before returning to this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.