GeezerVison

Argument Clinic: Touch source file if any output file changed #64595

Closed

bedevere-bot added the awaiting core review label

erlend-aasland requested review from larryhastings and ncoghlan

May 4, 2023 07:28

erlend-aasland added the skip news label

erlend-aasland commented

View reviewed changes

Comment thread

Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented

View reviewed changes

Comment thread

Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

This comment was marked as outdated.

erlend-aasland added 2 commits

May 4, 2023 11:58


          Pull in main

a6b0fda


          Adapt tests to new parse() behaviour

34a5770

erlend-aasland commented May 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

FTR, previously clinic output was written first; with this PR it is written last, as per @serhiy-storchaka's and @ncoghlan's comments, respectively #64595 (comment) and #64595 (comment).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented May 5, 2023

Copy link

Copy Markdown

Contributor Author

I consider this a non-controversial change, so I'm landing this today.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented

View reviewed changes

Comment thread

Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Tools/clinic/clinic.py

8d2aae3

erlend-aasland enabled auto-merge (squash)

May 5, 2023 12:17

erlend-aasland linked an issue

Argument Clinic: Touch source file if any output file changed #64595

that may be closed by this pull request

Closed

erlend-aasland merged commit 45a9e38 into python:main

bedevere-bot removed the awaiting core review label

erlend-aasland deleted the clinic-touch-src branch

May 5, 2023 12:54

carljm added a commit to carljm/cpython that referenced this pull request


          Merge branch 'main' into inlinecomp2

8a78a36

* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...

jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request

May 8, 2023


          pythongh-64595: Argument Clinic: Touch source file if any output file…

d3192a2

… changed (python#104152)

erlend-aasland mentioned this pull request

gh-64595: Fix regression in file write logic in Argument Clinic #106449

Merged

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request


          pythongh-64595: Fix regression in file write logic in Argument Clinic

6f5936a

Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507

ambv pushed a commit that referenced this pull request


          gh-64595: Fix regression in file write logic in Argument Clinic (#106449

9d1d4f9

)

Revert the two commits that introduced the regressions:

 - gh-104152
 - gh-104507

erlend-aasland mentioned this pull request

[3.12] gh-64595: Fix regression in file write logic in Argument Clinic (#106449) #106452

Merged

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request


          [3.12] pythongh-64595: Fix regression in file write logic in Argument…

b02430a

… Clinic (python#106449)

Revert the two commits that introduced the regressions:

 - pythongh-104152
 - pythongh-104507

(cherry picked from commit 9d1d4f9)

Co-authored-by: Erlend Aasland <[email protected]>

erlend-aasland added a commit that referenced this pull request