GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS by vstinner · Pull Request #107069 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Rename private C API constants:

  • Rename PY_MONITORING_UNGROUPED_EVENTS to _PY_MONITORING_UNGROUPED_EVENTS
  • Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS
  • Issue: Implement and document PEP 669. #103082

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythonGH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS
42b39e1 
Rename private C API constants:

* Rename PY_MONITORING_UNGROUPED_EVENTS to _PY_MONITORING_UNGROUPED_EVENTS
* Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS
@vstinner vstinner added skip news topic-C-API needs backport to 3.12 only security fixes labels Jul 22, 2023
@vstinner
vstinner requested a review from markshannon as a code owner July 22, 2023 21:03
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
Implement and document PEP 669. #103082
Closed
3 of 4 tasks
@bedevere-bot bedevere-bot added the awaiting core review label Jul 22, 2023
@vstinner

vstinner commented Jul 22, 2023

Copy link
Copy Markdown
Member Author

_Py_Monitors, _PyCoMonitoringData, PyCodeObject._co_monitoring are private, so mark also the two associate constants as private.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) July 22, 2023 21:06
@vstinner
vstinner merged commit 0927a2b into python:main Jul 22, 2023
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 22, 2023
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0927a2b25c059988e237108605ed8ab0c5459c53 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Jul 22, 2023
@vstinner
vstinner deleted the pymonitor branch July 22, 2023 21:37
@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-107075 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Jul 22, 2023
@vstinner
pythonGH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS (…
a4058ab 
…python#107069)

Rename private C API constants:

* Rename PY_MONITORING_UNGROUPED_EVENTS to _PY_MONITORING_UNGROUPED_EVENTS
* Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS

(cherry picked from commit 0927a2b)
vstinner added a commit that referenced this pull request Jul 22, 2023
@vstinner
[3.12] GH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS (
0d4a766 
#107069) (#107075)

GH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS (#107069)

Rename private C API constants:

* Rename PY_MONITORING_UNGROUPED_EVENTS to _PY_MONITORING_UNGROUPED_EVENTS
* Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS

(cherry picked from commit 0927a2b)
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 23, 2023
@vstinner @jtcave
pythonGH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS (…
44ae35a 
…python#107069)

Rename private C API constants:

* Rename PY_MONITORING_UNGROUPED_EVENTS to _PY_MONITORING_UNGROUPED_EVENTS
* Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS
mementum pushed a commit to mementum/cpython that referenced this pull request Jul 23, 2023
@vstinner @mementum
pythonGH-103082: Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS (…
eb2282d 
…python#107069)

Rename private C API constants:

* Rename PY_MONITORING_UNGROUPED_EVENTS to _PY_MONITORING_UNGROUPED_EVENTS
* Rename PY_MONITORING_EVENTS to _PY_MONITORING_EVENTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.