GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105059: Use GCC/clang extension for PyObject union by vstinner · Pull Request #107232 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Anonymous union is new in C11. To prevent compiler warning, use Clang and GCC extension on C99 and older.

  • Issue: object.h uses an anonymous union in a struct (older C incompatible) #105059

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105059: Use GCC/clang extension for PyObject union
43d0a5b 
Anonymous union is new in C11. To prevent compiler warning, use Clang
and GCC extension on C99 and older.
@vstinner vstinner added the skip news label Jul 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
object.h uses an anonymous union in a struct (older C incompatible) #105059
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 25, 2023
@vstinner vstinner added the needs backport to 3.12 only security fixes label Jul 25, 2023
@vstinner
vstinner enabled auto-merge (squash) July 25, 2023 11:55
@vstinner vstinner mentioned this pull request Jul 25, 2023
[DRAFT] gh-105059: C99 avoids PyObject.ob_refcnt union #105767
Closed
@vstinner
vstinner merged commit 6261585 into python:main Jul 25, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 25, 2023
@miss-islington

miss-islington commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@vstinner @miss-islington
pythongh-105059: Use GCC/clang extension for PyObject union (pythonGH…
627d528 
…-107232)

Anonymous union is new in C11. To prevent compiler warning
when using -pedantic compiler option, use Clang and GCC
extension on C99 and older.
(cherry picked from commit 6261585)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 25, 2023

Copy link
Copy Markdown

GH-107236 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 25, 2023
@vstinner
vstinner deleted the incref_union branch July 25, 2023 12:29
vstinner added a commit that referenced this pull request Jul 25, 2023
@miss-islington @vstinner
[3.12] gh-105059: Use GCC/clang extension for PyObject union (GH-107232…
0cf5f6a 
…) (#107236)

gh-105059: Use GCC/clang extension for PyObject union (GH-107232)

Anonymous union is new in C11. To prevent compiler warning
when using -pedantic compiler option, use Clang and GCC
extension on C99 and older.
(cherry picked from commit 6261585)

Co-authored-by: Victor Stinner <[email protected]>
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@vstinner @jtcave
pythongh-105059: Use GCC/clang extension for PyObject union (python#1…
d9e16c2 
…07232)

Anonymous union is new in C11. To prevent compiler warning
when using -pedantic compiler option, use Clang and GCC
extension on C99 and older.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.