GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) by ericsnowcurrently · Pull Request #110713 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We tried this before with a dict and for all interned strings. That ran into problems due to interpreter isolation. However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning. Here we circle back to using a global cache, but only for statically allocated strings. We also use a more-basic _Py_hashtable_t for that global cache instead of a dict.

Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter. Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter.

(cherry-picked from commit b72947a)

(This supersedes gh-107358.)

  • Issue: Global String Objects are Interned Only in the First Interpreter #106931

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently
[3.12] pythongh-106931: Intern Statically Allocated Strings Globally (p…
4e60828
…ythongh-107272)

We tried this before with a dict and for all interned strings.  That ran into problems due to interpreter isolation.  However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning.  Here we circle back to using a global cache, but only for statically allocated strings.  We also use a more-basic _Py_hashtable_t for that global cache instead of a dict.

Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter.  Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter.

(cherry-picked from commit b72947a)
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
This was referenced Oct 11, 2023
gh-106931: Intern Statically Allocated Strings Globally #107272
Merged
Global String Objects are Interned Only in the First Interpreter #106931
Closed
@ericsnowcurrently
ericsnowcurrently force-pushed the backport-b72947a-fix-interned-strings branch from 352cfd9 to 4e60828 Compare October 11, 2023 12:43
ericsnowcurrently added 2 commits October 11, 2023 08:11
@ericsnowcurrently
Fix test_sys.
9f6e18a
@ericsnowcurrently
Update python3.12.abi
6925f8f
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Oct 11, 2023
Yhg1s
Yhg1s reviewed Nov 20, 2023
View reviewed changes
Comment thread Include/internal/pycore_runtime.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

ericsnowcurrently added 4 commits November 20, 2023 11:17
@ericsnowcurrently
Move "cached_objects" down, for 3.12.0 layout compatibility.
8b74598
@ericsnowcurrently
Merge branch '3.12' into backport-b72947a-fix-interned-strings
9edfe39
@ericsnowcurrently
Merge branch '3.12' into backport-b72947a-fix-interned-strings
2a69220
@ericsnowcurrently
Update python3.12.abi
22b8038
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) November 27, 2023 23:25
@ericsnowcurrently
ericsnowcurrently merged commit 4f71f16 into python:3.12 Nov 27, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 27, 2023
@ericsnowcurrently
ericsnowcurrently deleted the backport-b72947a-fix-interned-strings branch November 27, 2023 23:57
@brettcannon brettcannon mentioned this pull request Nov 28, 2023
test_sys broken on Python 3.12 under WASI #112503
Closed
@brettcannon

brettcannon commented Nov 28, 2023

Copy link
Copy Markdown
Member

This broke the 3.12 WASI build: https://buildbot.python.org/all/#/builders/1124/builds/464/steps/11/logs/stdio .

Opened #112503 to track the fix (which is backporting a change made on main).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 29, 2023
[3.12] gh-112503: Fix test_sys on WASI #112505
Merged
ericsnowcurrently added a commit that referenced this pull request Nov 29, 2023
@ericsnowcurrently
[3.12] gh-112503: Fix test_sys on WASI (gh-112505)
3e6b328
Skip tests if no interpreters module.gh-110713 added some tests that use the interpreters module but did not accommodated builds that don't support subinterpreters (incl. an interpreters module).  We fix that here by catching ImportError and skipping tests as appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s left review comments
@pablogsal pablogsal pablogsal left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @brettcannon @Yhg1s @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.