GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: upgrade to python-docs-theme 2023.7 by hugovk · Pull Request #107617 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Aug 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The venv used on the docs server persists between deploys, therefore let's pin the theme so we get the version we want:

  • https://github.com/python/python-docs-theme/releases/tag/2023.7

This means we'll get the dark theme for 3.11 (aka the main https://docs.python.org/3/). We've already had it on https://docs.python.org/3.12/ and https://docs.python.org/3.13/ for a few months.

Let's also bump Sphinx to include the latest 6.x patch release:

  • https://www.sphinx-doc.org/en/master/changes.html#release-6-2-1-released-apr-25-2023

(We have another PR to upgrade Sphinx to 7.x, let's handle that separately: #99381)

📚 Documentation preview 📚: https://cpython-previews--107617.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Docs: upgrade to python-docs-theme 2023.7
469e528
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 4, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Aug 4, 2023
@hugovk hugovk added skip issue skip news labels Aug 4, 2023
@hugovk hugovk mentioned this pull request Aug 4, 2023
New release python/python-docs-theme#143
Closed
hauntsaninja
hauntsaninja approved these changes Aug 4, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 4, 2023
AA-Turner
AA-Turner approved these changes Aug 4, 2023
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially do >=2023.7, but fairly minor.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk

hugovk commented Aug 4, 2023

Copy link
Copy Markdown
Member Author

Good idea, I'll update it to >=2023.7.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Docs: upgrade to python-docs-theme 2023.7
25a785c
@hugovk
hugovk enabled auto-merge (squash) August 4, 2023 14:01
@hugovk
hugovk merged commit 19f32b2 into python:main Aug 4, 2023
@hugovk
hugovk deleted the bump-python-docs-theme branch August 4, 2023 14:16
@miss-islington

miss-islington commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 4, 2023
@miss-islington

miss-islington commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f32b24b2e1680ff9929bb64d681397b259c6fb 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hugovk Aug 4, 2023
@miss-islington

miss-islington commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 19f32b24b2e1680ff9929bb64d681397b259c6fb 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk added a commit to hugovk/cpython that referenced this pull request Aug 4, 2023
@hugovk
[3.12] Docs: upgrade to python-docs-theme 2023.7 (pythonGH-107617)
f882985 
(cherry picked from commit 19f32b2)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 4, 2023

Copy link
Copy Markdown

GH-107633 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 4, 2023
@bedevere-bot

bedevere-bot commented Aug 4, 2023

Copy link
Copy Markdown

GH-107634 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Aug 4, 2023
@hugovk
[3.11] Docs: upgrade to python-docs-theme 2023.7 (pythonGH-107617)
aed26c6 
(cherry picked from commit 19f32b2)

Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 4, 2023
@hugovk
[3.12] Docs: upgrade to python-docs-theme 2023.7 (GH-107617) (#107633)
28a9849 
(cherry picked from commit 19f32b2)
hugovk added a commit that referenced this pull request Aug 4, 2023
@hugovk
[3.11] Docs: upgrade to python-docs-theme 2023.7 (GH-107617) (#107634)
f978a79 
(cherry picked from commit 19f32b2)
@hugovk hugovk mentioned this pull request Oct 31, 2026
Docs: Upgrade Sphinx to 9.1 #159945
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @miss-islington @bedevere-bot @AA-Turner @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.