GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_REFS Builds by ericsnowcurrently · Pull Request #107750 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a follow-up to gh-107567 and gh-107733

  • Issue: TraceRefs build triggers assertion errors #107630

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs b…
d918a8a 
…uilds.
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 7, 2023
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, ncoghlan and warsaw as code owners August 7, 2023 21:19
@bedevere-bot bedevere-bot mentioned this pull request Aug 7, 2023
TraceRefs build triggers assertion errors #107630
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 7, 2023
@ericsnowcurrently

ericsnowcurrently commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

!buildbot TraceRefs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit d918a8a 🤖

The command will test the builders whose names match following regular expression: TraceRefs

The builders matched are:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

!buildbot .*TraceRefs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit d918a8a 🤖

The command will test the builders whose names match following regular expression: .*TraceRefs

The builders matched are:

  • AMD64 Arch Linux TraceRefs PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 7, 2023
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107751
Merged
@ericsnowcurrently

ericsnowcurrently commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

There's a big backlog on the tracerefs buildbot so I'm going to merge this now and follow-up after. This PR fixes the one failing test under Py_TRACE_REFS, so I expect it's good to go.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit 707018c into python:main Aug 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 7, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-tracerefs branch August 7, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.