GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107630: Initialize Each Interpreter's refchain Properly by ericsnowcurrently · Pull Request #107733 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This finishes fixing the crashes in Py_TRACE_REFS builds. We missed this part in gh-107567.

  • Issue: TraceRefs build triggers assertion errors #107630

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently
Initialize each interpreter's refchain properly.
1ca47d4
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 7, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Aug 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 6, 2023
TraceRefs build triggers assertion errors #107630
Closed
@ericsnowcurrently

ericsnowcurrently commented Aug 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I'll be backporting this to 3.12 manually. (See gh-107737.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
ericsnowcurrently merged commit 430632d into python:main Aug 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 7, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-tracerefs branch August 7, 2023 19:15
This was referenced Aug 7, 2023
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107737
Closed
gh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_REFS Builds #107750
Merged
[3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters #107751
Merged
ericsnowcurrently added a commit that referenced this pull request Aug 7, 2023
@ericsnowcurrently
gh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_REFS Bui…
707018c
…lds (gh-107750)

This is a follow-up to gh-107567 and gh-107733.

We skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.  The test breaks interpreter isolation a little, which doesn't work well with Py_TRACE_REFS builds, so I feel fine about skipping the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.