GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-107080: Fix Py_TRACE_REFS Crashes Under Isolated Subinterpreters by ericsnowcurrently · Pull Request #107751 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is effectively an unrevert of gh-107599 (reverted by gh-107648), with the additional fix from gh-107733 and gh-107750 added in.

  • Issue: test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain #107080

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 3 commits August 7, 2023 12:11
@ericsnowcurrently
Unrevert "[3.12] pythongh-107080: Fix Py_TRACE_REFS Crashes Under Iso…
6f8b84f 
…lated Subinterpreters (pythongh-107567) (python#107599)".

This reverts commit 6e4eec7 (pythongh-107648).
@ericsnowcurrently
Initialize each interpreter's refchain properly.
24a455a
@ericsnowcurrently
Skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs b…
6eb6e60 
…uilds.
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, encukou, ncoghlan and warsaw as code owners August 7, 2023 21:26
@bedevere-bot bedevere-bot mentioned this pull request Aug 7, 2023
test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain #107080
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 7, 2023
@ericsnowcurrently

ericsnowcurrently commented Aug 7, 2023

Copy link
Copy Markdown
Member Author

!buildbot .*TraceRefs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 6eb6e60 🤖

The command will test the builders whose names match following regular expression: .*TraceRefs

The builders matched are:

  • AMD64 Arch Linux TraceRefs PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Aug 7, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 8, 2023
TraceRefs build triggers assertion errors #107630
Closed
@brettcannon
brettcannon removed their request for review August 10, 2023 17:33
@serhiy-storchaka serhiy-storchaka linked an issue Aug 16, 2023 that may be closed by this pull request
test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain #107080
Closed
@Yhg1s
Yhg1s merged commit aa9707d into python:3.12 Aug 16, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 16, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-tracerefs-3.12 branch August 16, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test__xxsubinterpreters: test_already_running() crash randomly on Python built with TraceRefs: invalid object chain

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @bedevere-bot @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.