GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-103082: Document PEP-669: Low Impact Monitoring for CPython by markshannon · Pull Request #107772 · python/cpython

Conversation

markshannon commented Aug 8, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Initial draft

📚 Documentation preview 📚: https://cpython-previews--107772.org.readthedocs.build/

Issue: Implement and document PEP 669. #103082

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

markshannon added 3 commits

August 4, 2023 21:12


          Add what's new for PEP 669

22e5d83


          Document sys.monitoring. First draft.

6e5a435


          Fix sphinx errors

e373cbe

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

Aug 8, 2023

markshannon changed the title ~~Document PEP-669: Low Impact Monitoring for CPython~~ GH-103082: Document PEP-669: Low Impact Monitoring for CPython

Aug 8, 2023

bedevere-bot mentioned this pull request

Jul 22, 2023

Implement and document PEP 669. #103082

Closed

3 of 4 tasks

jacobtylerwalls reviewed

Aug 9, 2023

View reviewed changes

jacobtylerwalls left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo while here, cheers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Aug 13, 2023

View reviewed changes

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

markshannon added 7 commits

August 28, 2023 01:02


          Address review comments

c648e70


          Merge branch 'main' into doc-669

ed94e2e


          Use add more cross-references

c15022c


          Fix note

5d54704


          Fix lint

7a500bd


          Fix lint

bb4100c


          Another attempt to fix the syntax

181843e

markshannon marked this pull request as ready for review

August 31, 2023 10:40

AA-Turner reviewed

Sep 1, 2023

View reviewed changes

AA-Turner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to remove double-spaces, and to remove an unneeded sys.monitoring prefix from the function definitions -- they'll be added by Sphinx regardless as of the .. module:: directive at the top of the file, and removing them helps with line length/readability.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner commented Sep 1, 2023

Copy link

Copy Markdown

Member

The patch mentiond for conf.py is:

diff --git a/Doc/conf.py b/Doc/conf.py
index 16fd8bf2571..901b977fd71 100644
--- a/Doc/conf.py
+++ b/Doc/conf.py
@@ -157,6 +157,8 @@
     ('envvar', 'USER'),
     ('envvar', 'USERNAME'),
     ('envvar', 'USERPROFILE'),
+    # sys.monitoring ignores
+    ('py:class', 'range(6)'),
 ]

 # Temporary undocumented names.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Sep 1, 2023

View reviewed changes

Comment thread

Doc/library/sys.monitoring.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

markshannon and others added 8 commits

September 5, 2023 02:16


          Remove double space

200e4a3


          Update Doc/library/sys.monitoring.rst

fb16167

Co-authored-by: Adam Turner <[email protected]>


          Update Doc/library/sys.monitoring.rst

bfb3b1d

Co-authored-by: Adam Turner <[email protected]>


          Update Doc/library/sys.monitoring.rst

Co-authored-by: Adam Turner <[email protected]>


          Update Doc/library/sys.monitoring.rst

Co-authored-by: Adam Turner <[email protected]>


          Update Doc/library/sys.monitoring.rst

Co-authored-by: Adam Turner <[email protected]>


          Apply suggestions from code review

a943679

Co-authored-by: Adam Turner <[email protected]>


          Drop use of range(6) to avoid confusing sphinx

002e744

markshannon merged commit 8b515f6 into python:main

Sep 5, 2023

Yhg1s commented Sep 5, 2023

Copy link

Copy Markdown

Member

Is this getting backported to 3.12?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon commented Sep 5, 2023

Copy link

Copy Markdown

Member Author

Yes, it should be.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon added the needs backport to 3.12 only security fixes label

Sep 5, 2023

miss-islington commented Sep 5, 2023

Copy link

Copy Markdown

Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Sep 5, 2023

Copy link

Copy Markdown

GH-108909 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Sep 5, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 5, 2023


          pythonGH-103082: Document PEP-669: Low Impact Monitoring for CPython (p…

75d5382

…ythonGH-107772)

(cherry picked from commit 8b515f6)

Co-authored-by: Mark Shannon <[email protected]>

markshannon deleted the doc-669 branch

September 5, 2023 12:52

Yhg1s pushed a commit that referenced this pull request

Sep 5, 2023


          [3.12] GH-103082: Document PEP-669: Low Impact Monitoring for CPython (…

578b3ea

…GH-107772) (#108909)

GH-103082: Document PEP-669: Low Impact Monitoring for CPython (GH-107772)
(cherry picked from commit 8b515f6)

Co-authored-by: Mark Shannon <[email protected]>

Reviewers

AA-Turner

AA-Turner left review comments

+1 more reviewer

jacobtylerwalls

jacobtylerwalls left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

markshannon commented Aug 8, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacobtylerwalls left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner commented Sep 1, 2023

Uh oh!

Uh oh!

Yhg1s commented Sep 5, 2023

Uh oh!

markshannon commented Sep 5, 2023

Uh oh!

miss-islington commented Sep 5, 2023

Uh oh!

bedevere-bot commented Sep 5, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

markshannon commented Aug 8, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.