GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Run sphinx-lint on Misc/NEWS.d/next/ by hugovk · Pull Request #108212 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Aug 21, 2023

Copy link
Copy Markdown
Member

Follow on from #105750.

Before that PR, we used to run sphinx-lint on Doc/ and Misc/NEWS.d/next/

After, we only ran sphinx-lint on Doc/. I think leaving out Misc/NEWS.d/next/ was an oversight on my part, let's add it back.

In the meantime, a handful of NEWS warnings had slipped through, this PR also fixes them.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 2 commits August 21, 2023 14:52
@hugovk
Run sphinx-lint on Misc/NEWS.d/next/
a790182
@hugovk
Fix sphinx-lint warnings in Misc/NEWS.d/next/
e038a4a
@hugovk hugovk added the needs backport to 3.12 only security fixes label Aug 21, 2023
@hugovk
hugovk requested a review from AlexWaygood as a code owner August 21, 2023 12:07
@bedevere-bot bedevere-bot added the awaiting core review label Aug 21, 2023
@hugovk hugovk added the skip issue label Aug 21, 2023
@AlexWaygood AlexWaygood added the skip issue label Aug 21, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Aug 21, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Although I do not see a difference in some files. Why are they marked as different?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 21, 2023
@hugovk

hugovk commented Aug 21, 2023

Copy link
Copy Markdown
Member Author

They were "No newline at end of file":

Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst:1: found an unbalanced inline literal markup. (unbalanced-inline-literals-delimiters)
Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2020-05-03-00-33-15.bpo-18319.faPTlx.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2020-05-03-00-33-15.bpo-18319.faPTlx.rst:2: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Core and Builtins/2023-06-24-10-34-27.gh-issue-105775.OqjoGV.rst:1: No newline at end of file. (missing-final-newline)
Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst:2: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst:3: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Core and Builtins/2023-07-04-04-50-14.gh-issue-100288.yNQ1ez.rst:3: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2023-06-30-16-42-44.gh-issue-106263.tk-t93.rst:2: No newline at end of file. (missing-final-newline)
Misc/NEWS.d/next/Build/2023-07-28-18-17-33.gh-issue-106881.U3Ezdq.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Core and Builtins/2023-07-27-11-47-29.gh-issue-104432.oGHF-z.rst:2: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2023-08-07-14-12-07.gh-issue-107715.238r2f.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2023-07-16-10-40-34.gh-issue-106789.NvyE3C.rst:1: role use a single backtick, double backtick found. (role-with-double-backticks)
Misc/NEWS.d/next/Library/2023-07-16-10-40-34.gh-issue-106789.NvyE3C.rst:1: role use a single backtick, double backtick found. (role-with-double-backticks)
Misc/NEWS.d/next/Library/2023-06-25-12-28-55.gh-issue-106075.W7tMRb.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Core and Builtins/2023-07-27-11-18-04.gh-issue-106078.WEy2Yn.rst:1: No newline at end of file. (missing-final-newline)
Misc/NEWS.d/next/Library/2023-07-22-21-57-34.gh-issue-107089.Dnget2.rst:2: No newline at end of file. (missing-final-newline)

https://github.com/hugovk/cpython/actions/runs/5925848833/job/16066091943
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Aug 21, 2023
@hugovk

hugovk commented Aug 21, 2023

Copy link
Copy Markdown
Member Author

The 3.12 backport will only need the first commit, I'll backport it manually.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Aug 21, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few optional suggestions:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2023-07-14-16-54-13.gh-issue-106752.BT1Yxw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-08-07-14-12-07.gh-issue-107715.238r2f.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk and others added 2 commits August 21, 2023 15:22
@hugovk @AlexWaygood
Turn into references
7d85576 
Co-authored-by: Alex Waygood <[email protected]>
@hugovk @AlexWaygood
Turn into reference
8af98b5 
Co-authored-by: Alex Waygood <[email protected]>
@hugovk
hugovk enabled auto-merge (squash) August 21, 2023 12:23
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108213 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 71962e5 into python:main Aug 21, 2023
@hugovk
hugovk deleted the pre-commit-sphinx-lint-news branch August 21, 2023 13:13
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Aug 21, 2023
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

There's a new commit after the PR has been approved.

@serhiy-storchaka, @AlexWaygood: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested review from AlexWaygood and serhiy-storchaka August 21, 2023 13:14
Yhg1s pushed a commit that referenced this pull request Aug 21, 2023
@hugovk
[3.12] Run sphinx-lint on Misc/NEWS.d/next/ (GH-108212) (#108213)
90a22ea 
Run sphinx-lint on Misc/NEWS.d/next/
@hugovk hugovk mentioned this pull request Aug 21, 2023
[3.11] Trim trailing whitespace and test on CI (GH-104275) #108215
Merged
Yhg1s added a commit to Yhg1s/cpython that referenced this pull request Aug 21, 2023
@Yhg1s
Fix lint warnings in Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-…
03e2f30 
…issue-105736.NJsH7r.rst

(effectively a backport of pythonGH-108212).
@Yhg1s Yhg1s mentioned this pull request Aug 21, 2023
[3.12] Fix sphinx-lint issue now that lint runs on Misc/NEWS.d #108237
Merged
Yhg1s added a commit that referenced this pull request Aug 21, 2023
@Yhg1s
[3.12] Fix sphinx-lint issue now that lint runs on Misc/NEWS.d (#108237)
bc97eb7 
Fix lint warnings in Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst
(effectively a backport of GH-108212).
@hugovk hugovk mentioned this pull request Aug 22, 2023
[3.11] Docs: move sphinx-lint to pre-commit (GH-105750) #108276
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @bedevere-bot @serhiy-storchaka @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.