GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] Trim trailing whitespace and test on CI (GH-104275) by hugovk · Pull Request #108215 · python/cpython

Conversation

hugovk commented Aug 21, 2023

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk and others added 4 commits

August 21, 2023 16:17


          Add pre-commit config and test on CI

9327cf7


          Trim trailing whitespace

cd547a2


          Add Alex to CODEOWNERS

b40bc8e

Co-authored-by: Alex Waygood <[email protected]>


          Add concurrency key to avoid duplicate builds

877393b

hugovk requested review from a team, 1st1, asvetlov, ezio-melotti and tiran as code owners

August 21, 2023 13:33

bedevere-bot added skip issue skip news labels

Aug 21, 2023

bedevere-bot mentioned this pull request

Aug 21, 2023

Trim trailing whitespace and test on CI #104275

Merged

bedevere-bot added the awaiting core review label

Aug 21, 2023

hugovk requested review from AlexWaygood and removed request for a team, 1st1, asvetlov and tiran

August 21, 2023 13:35

hugovk commented Aug 21, 2023

Copy link

Copy Markdown

Member Author

I'll follow this with a combined backport of #105750 and #108212.

I left them out of this one to keep things separate and clearer.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reviewed

Aug 22, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this diff is removing invisible pagebreak characters. For most of these cases, we should delete the whole line rather than just stripping the "trailing whitespace" from the line:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

AlexWaygood commented Aug 22, 2023

Copy link

Copy Markdown

Member

See #102531 for where we removed invisible pagebreak characters from the main branch. (@hugovk, is it worth seeing if that PR could just be cleanly backported to 3.11?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk commented Aug 22, 2023

Copy link

Copy Markdown

Member Author

Good idea, and it backported cleanly 🎉 #108266

AlexWaygood reacted with rocket emoji

All reactions

🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Revert "Trim trailing whitespace"

834cc88

This reverts commit cd547a2.

This comment was marked as outdated.

hugovk commented Aug 22, 2023

Copy link

Copy Markdown

Member Author

Reverted Trim trailing whitespace, will update 3.11 into here, and then see what's left to fix.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added 2 commits

August 22, 2023 11:55


          Merge branch '3.11' into 3.11-pre-commit

1e42568


          Trim the trailing whitespace

7cbfc5f

hugovk commented Aug 22, 2023

Copy link

Copy Markdown

Member Author

And autofixed via pre-commit, let's check these changes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

b0f574b

Co-authored-by: Alex Waygood <[email protected]>

hugovk commented Aug 22, 2023

Copy link

Copy Markdown

Member Author

And applied the two suggestions which were still available.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood approved these changes

Aug 22, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 22, 2023

hugovk merged commit d678ee7 into python:3.11

Aug 22, 2023

hugovk deleted the 3.11-pre-commit branch

August 22, 2023 09:57

bedevere-bot removed the awaiting merge label

Aug 22, 2023

hugovk commented Aug 22, 2023

Copy link

Copy Markdown

Member Author

Thank you very much for the reviews!

AlexWaygood reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk mentioned this pull request

Aug 22, 2023

[3.11] Docs: move sphinx-lint to pre-commit (GH-105750) #108276

Merged

Reviewers

AlexWaygood

AlexWaygood approved these changes

ezio-melotti

Awaiting requested review from ezio-melotti

ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.