GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102507 Remove invisible pagebreak characters by JosephSBoyle · Pull Request #102531 · python/cpython

Conversation

@JosephSBoyle

@JosephSBoyle JosephSBoyle commented Mar 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Removes invisible pagebreak chars from the repository.

These chars are not visible in the gh-diff, but code editors should display them. For instance VSCode displays it as this strange red box:

image

  • Issue: Remove invisible pagebreak chars from the standard library #102507

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JosephSBoyle
JosephSBoyle requested a review from a team as a code owner March 8, 2023 11:13
@bedevere-bot bedevere-bot mentioned this pull request Mar 8, 2023
Remove invisible pagebreak chars from the standard library #102507
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 8, 2023
@JosephSBoyle
JosephSBoyle marked this pull request as draft March 8, 2023 11:16
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-102507 branch 2 times, most recently from c1a6775 to a236e91 Compare March 8, 2023 11:26
@JosephSBoyle JosephSBoyle closed this Mar 8, 2023
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-102507 branch from a236e91 to 7d801f2 Compare March 8, 2023 11:29
@JosephSBoyle
Remove invisible pagebreak characters
d65d478
@JosephSBoyle JosephSBoyle reopened this Mar 8, 2023
JosephSBoyle
JosephSBoyle commented Mar 8, 2023
View reviewed changes
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JosephSBoyle
JosephSBoyle commented Mar 8, 2023
View reviewed changes
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle marked this pull request as ready for review March 8, 2023 11:43
@AlexWaygood AlexWaygood added the skip news label Mar 8, 2023
AlexWaygood
AlexWaygood reviewed Mar 8, 2023
View reviewed changes
Comment thread Lib/email/generator.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/i18n/pygettext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
Add missing newlines (pep-8)
2a8316e
@JosephSBoyle
JosephSBoyle force-pushed the fix-issue-102507 branch from a8f63b2 to 2a8316e Compare March 8, 2023 12:39
@JosephSBoyle
Fix mangled non-english characters in pygettext.py
0e870c0
@AlexWaygood

AlexWaygood commented Mar 8, 2023

Copy link
Copy Markdown
Member

FYI we much prefer merge commits over rebases in the CPython repo, where possible. Rebases (well, force-pushes in general) interact quite badly with the GitHub UI, making it quite hard to see what changed in between commits and making incremental review quite difficult. Everything's squash-merged in the end anyway, so a messy git history on a PR is usually nothing to worry about!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JosephSBoyle and others added 2 commits March 8, 2023 12:47
@JosephSBoyle
Add missing newline
f5d7896
@JosephSBoyle
Merge branch 'main' into fix-issue-102507
f09bd16
@JosephSBoyle

JosephSBoyle commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

FYI we much prefer merge commits over rebases in the CPython repo, where possible. Rebases (well, force-pushes in general) interact quite badly with the GitHub UI, making it quite hard to see what changed in between commits and making incremental review quite difficult. Everything's squash-merged in the end anyway, so a messy git history on a PR is usually nothing to worry about!

Aha, that makes sense. Thanks for the headsup @AlexWaygood 🙇
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JosephSBoyle
JosephSBoyle requested a review from AlexWaygood March 8, 2023 12:58
@AlexWaygood
Revert undesirable changes to pygettext
ec158cd
AlexWaygood
AlexWaygood approved these changes Mar 8, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 8, 2023
@AlexWaygood AlexWaygood linked an issue Mar 8, 2023 that may be closed by this pull request
Remove invisible pagebreak chars from the standard library #102507
Closed
@sobolevn

sobolevn commented Mar 8, 2023

Copy link
Copy Markdown
Member

I once saw a similar PR that was rejected :(
But, I cannot remember by who and why
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Mar 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I once saw a similar PR that was rejected :( But, I cannot remember by who and why

It was rejected because Guido said we should do it all at once if we wanted to do it, rather than doing it just in one file. And that's exactly what @JosephSBoyle has done here :)
sobolevn and JosephSBoyle reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood merged commit b097925 into python:main Mar 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 8, 2023
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
@hugovk hugovk mentioned this pull request May 7, 2023
Trim trailing whitespace and test on CI #104275
Merged
@AlexWaygood AlexWaygood mentioned this pull request Aug 22, 2023
[3.11] Trim trailing whitespace and test on CI (GH-104275) #108215
Merged
@hugovk hugovk added the needs backport to 3.11 only security fixes label Aug 22, 2023
@miss-islington

miss-islington commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @JosephSBoyle for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2023
@JosephSBoyle @AlexWaygood @miss-islington
pythongh-102507 Remove invisible pagebreak characters (pythonGH-102531)
61d3a8a 
(cherry picked from commit b097925)

Co-authored-by: JosephSBoyle <[email protected]>
Co-authored-by: AlexWaygood <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 22, 2023

Copy link
Copy Markdown

GH-108266 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 22, 2023
AlexWaygood added a commit that referenced this pull request Aug 22, 2023
@miss-islington @JosephSBoyle @AlexWaygood
[3.11] gh-102507 Remove invisible pagebreak characters (GH-102531) (#…
dd0a1f9 
…108266)

gh-102507 Remove invisible pagebreak characters (GH-102531)
(cherry picked from commit b097925)

Co-authored-by: JosephSBoyle <[email protected]>
Co-authored-by: AlexWaygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove invisible pagebreak chars from the standard library

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JosephSBoyle @AlexWaygood @sobolevn @miss-islington @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.