GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs by erlend-aasland · Pull Request #108281 · python/cpython

Conversation

erlend-aasland commented Aug 22, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

create_function(name, nargs, callable, ...)
create_aggregate(name, nargs, callable)

The affected parameters will become positional-only in Python 3.15.

Issue: Clean up sqlite3.Connection APIs #108278

📚 Documentation preview 📚: https://cpython-previews--108281.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-108278: Clean up some sqlite3 connection APIs

4f89b4c

Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

- create_function(name, nargs, callable, ...)
- create_aggregate(name, nargs, callable)

Deprecate passing the callback as a keyword argument, for the following
sqlite3.Connection APIs:

- set_authorizer(callback)
- set_progress_handler(callback, n)
- set_trace_callback(callback)

The affected parameters will become positional-only in Python 3.15.

erlend-aasland requested a review from serhiy-storchaka

August 22, 2023 11:51

bedevere-bot mentioned this pull request

Aug 22, 2023

Clean up sqlite3.Connection APIs #108278

Closed


          Sphinx fixup

634217b

erlend-aasland changed the title ~~gh-108278: Clean up some sqlite3 connection APIs~~ gh-108278: Clean up sqlite3.Connection APIs

Aug 22, 2023

erlend-aasland marked this pull request as ready for review

August 22, 2023 20:05

erlend-aasland requested a review from berkerpeksag as a code owner

August 22, 2023 20:05

bedevere-bot added the awaiting core review label

Aug 22, 2023

erlend-aasland added 4 commits

August 23, 2023 10:34


          Pull in main

7fa3edb


          Restrict PR to only touch the UDF creation APIs

cedd33a


          Update docs

54e35d5


          Add test

833197a

erlend-aasland changed the title ~~gh-108278: Clean up sqlite3.Connection APIs~~ gh-108278: Deprecate passing the three first params as keyword args for sqlite3 UDF creation APIs

Aug 23, 2023

erlend-aasland commented Aug 23, 2023

Copy link

Copy Markdown

Contributor Author

I updated the PR to only affect UDF creation APIs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented

Aug 23, 2023

View reviewed changes

Comment thread

Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Doc/whatsnew/3.13.rst

661cd7a

erlend-aasland commented Aug 24, 2023

Copy link

Copy Markdown

Contributor Author

I'd like to land this; are you ok with the change, @serhiy-storchaka?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Pull in main

f72c5e9

erlend-aasland commented Aug 28, 2023

Copy link

Copy Markdown

Contributor Author

I'm landing this. It is for main only, so we have until 3.13 feature freeze (~May 2024) to adjust things or even revert.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Aug 28, 2023

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_sqlite3/test_userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 28, 2023

erlend-aasland commented Aug 28, 2023

Copy link

Copy Markdown

Contributor Author

LGTM, but please get an approval of yet one core developer. Has this change been discussed with a wider audience?

I posted a topic on Discourse. Brett and Berker left a "heart" reaction; I did not get any discouragements. Since Berker also is a code owner for the sqlite3 code, I count that as fairly strong support.

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 2 commits

August 28, 2023 14:46


          Pull in main

37205c4


          Address review: inline tests

15cf809

serhiy-storchaka commented Aug 28, 2023

Copy link

Copy Markdown

Member

Well, then go ahead!

erlend-aasland reacted with hooray emoji

erlend-aasland reacted with heart emoji

All reactions

🎉 1 reaction
❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland enabled auto-merge (squash)

August 28, 2023 13:08

erlend-aasland merged commit 4116592 into python:main

Aug 28, 2023

bedevere-bot added awaiting core review and removed awaiting merge labels

Aug 28, 2023

bedevere-bot commented Aug 28, 2023

Copy link

Copy Markdown

There's a new commit after the PR has been approved.

@serhiy-storchaka: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from serhiy-storchaka

August 28, 2023 13:32

vstinner pushed a commit to vstinner/cpython that referenced this pull request

Aug 28, 2023


          pythongh-108278: Deprecate passing the three first params as keyword …

e4ede8e

…args for sqlite3 UDF creation APIs (python#108281)

Deprecate passing name, number of arguments, and the callable as keyword
arguments, for the following sqlite3.Connection APIs:

- create_function(name, nargs, callable, ...)
- create_aggregate(name, nargs, callable)

The affected parameters will become positional-only in Python 3.15.

erlend-aasland deleted the sqlite/cleanup-connection-apis branch

August 28, 2023 19:22

erlend-aasland mentioned this pull request

Aug 29, 2023

gh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword #108632

Merged

Reviewers

berkerpeksag

Awaiting requested review from berkerpeksag

serhiy-storchaka

Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Aug 23, 2023

Uh oh!

Uh oh!

erlend-aasland commented Aug 24, 2023

Uh oh!

erlend-aasland commented Aug 28, 2023

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erlend-aasland commented Aug 28, 2023

Uh oh!

serhiy-storchaka commented Aug 28, 2023

Uh oh!

bedevere-bot commented Aug 28, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

erlend-aasland commented Aug 22, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.