GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword by erlend-aasland · Pull Request #108632 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 29, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Deprecate passing the callback callable by keyword for the following
sqlite3.Connection APIs:

  • set_authorizer(authorizer_callback)
  • set_progress_handler(progress_handler, ...)
  • set_trace_callback(trace_callback)

The affected parameters will become positional-only in Python 3.15.

  • Issue: Clean up sqlite3.Connection APIs #108278

📚 Documentation preview 📚: https://cpython-previews--108632.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-108278: Deprecate passing the first param of sqlite3.Connect…
a207531 
…ion callback APIs by keyword

Deprecate passing the callback callable by keyword for the following
sqlite3.Connection APIs:

- set_authorizer(authorizer_callback)
- set_progress_handler(progress_handler, ...)
- set_trace_callback(trace_callback)

The affected parameters will become positional-only in Python 3.15.
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 29, 2023 12:38
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka August 29, 2023 12:38
@bedevere-bot bedevere-bot mentioned this pull request Aug 28, 2023
Clean up sqlite3.Connection APIs #108278
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 29, 2023
@erlend-aasland
Add NEWS
fa95c73
@erlend-aasland

erlend-aasland commented Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

Also fixup the indent of the versionchanged directives added in gh-108281
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Aug 29, 2023
View reviewed changes
Comment thread Lib/test/test_sqlite3/test_userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Aug 29, 2023
View reviewed changes
Comment thread Lib/test/test_sqlite3/test_userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Aug 29, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should not n in set_progress_handler() be positional-only too?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 29, 2023
@erlend-aasland

erlend-aasland commented Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, but should not n in set_progress_handler() be positional-only too?

I am not sure. I left a comment regarding this on the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Aug 29, 2023

Copy link
Copy Markdown
Member

I am not sure too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

I am not sure too.

We can always deprecate passing n by keyword at a later time; either later in 3.13 development, or in a following release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Make the docstring of set_progress_handler() clearer
dc75cbc
@erlend-aasland

erlend-aasland commented Aug 29, 2023

Copy link
Copy Markdown
Contributor Author

I posted about this on Discourse, and got encouraging reactions from Brett Cannon and Berker Peksag. (Berker is also an sqlite3 code owner.) Together with Serhiy's approval, I intend to land this.

It is still very early in the 3.13 development phase, so we have plenty of time to adjust or even revert this feature.

Thanks for raising the discussions on the issue, and thanks for the review, Serhiy!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 0b0c1d0 into python:main Aug 29, 2023
@erlend-aasland
erlend-aasland deleted the sqlite/cleanup-callback-apis branch August 29, 2023 20:02
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Aug 29, 2023
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@bedevere-bot
bedevere-bot requested a review from serhiy-storchaka August 29, 2023 20:38
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 29, 2023
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
carljm added a commit to carljm/cpython that referenced this pull request Aug 30, 2023
@carljm
Merge branch 'main' into icompexc
37377e6 
* main:
  pythongh-108520: Fix bad fork detection in nested multiprocessing use case (python#108568)
  pythongh-108590: Revert pythongh-108657 (commit 400a1ce) (python#108686)
  pythongh-108494: Argument Clinic: Document how to generate code that uses the limited C API (python#108584)
  Document Python build requirements (python#108646)
  pythongh-101100: Fix Sphinx warnings in the Logging Cookbook (python#108678)
  Fix typo in multiprocessing docs (python#108666)
  pythongh-108669: unittest: Fix documentation for TestResult.collectedDurations (python#108670)
  pythongh-108590: Fix sqlite3.iterdump for invalid Unicode in TEXT columns (python#108657)
  Revert "pythongh-103224: Use the realpath of the Python executable in `test_venv` (pythonGH-103243)" (pythonGH-108667)
  pythongh-106320: Remove private _Py_ForgetReference() (python#108664)
  Mention Ellipsis pickling in the docs (python#103660)
  Revert "Use non alternate name for Kyiv (pythonGH-108533)" (pythonGH-108649)
  pythongh-108278: Deprecate passing the first param of sqlite3.Connection callback APIs by keyword (python#108632)
  pythongh-108455: peg_generator: install two stubs packages before running mypy (python#108637)
  pythongh-107801: Improve the accuracy of io.IOBase.seek docs (python#108268)
@gpshead gpshead mentioned this pull request Sep 30, 2024
[3.13] GH-124567: Revert the Incremental GC in 3.13 #124770
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.