GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108765: Move stat() fiddling from pyport.h to fileutils.h by vstinner · Pull Request #108854 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Cleanup header files #108765

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108765: Move stat() fiddling from pyport.h to fileutils.h
9f4de1c
@vstinner vstinner added the skip news label Sep 3, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Sep 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 3, 2023
C API: Cleanup header files #108765
Closed
@vstinner

vstinner commented Sep 3, 2023

Copy link
Copy Markdown
Member Author

This change is safe. It does not change any API, it only moves code from pyport.h to fileutils.h, but both header files are included by Python.h (which is the only header which must be included).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) September 3, 2023 21:14
@vstinner vstinner added the topic-C-API label Sep 3, 2023
@vstinner
vstinner merged commit c2ec174 into python:main Sep 3, 2023
@vstinner
vstinner deleted the stat_fiddling branch September 3, 2023 21:32
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 3, 2023
@moreal moreal mentioned this pull request Jun 27, 2025
gh-108765: fix comment about macro definitions in _stat.c post GH-108854 #136027
Merged
picnixz pushed a commit that referenced this pull request Jun 27, 2025
@moreal
gh-108765: fix comment about macro definitions in _stat.c post GH-1…
0141e7f 
…08854 (#136027)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@moreal @miss-islington
pythongh-108765: fix comment about macro definitions in _stat.c post …
94ead81 
…pythonGH-108854 (pythonGH-136027)

(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@moreal @miss-islington
pythongh-108765: fix comment about macro definitions in _stat.c post …
73da079 
…pythonGH-108854 (pythonGH-136027)

(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
picnixz pushed a commit that referenced this pull request Jun 27, 2025
@miss-islington @moreal
[3.13] gh-108765: fix comment about macro definitions in _stat.c post
ad1b0c9 
GH-108854 (GH-136027) (#136044)

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 (GH-136027)
(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
picnixz pushed a commit that referenced this pull request Jun 27, 2025
@miss-islington @moreal
[3.14] gh-108765: fix comment about macro definitions in _stat.c post
eff347c 
GH-108854 (GH-136027) (#136043)

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 (GH-136027)
(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@moreal @AndPuQing
pythongh-108765: fix comment about macro definitions in _stat.c post …
dd67d75 
…pythonGH-108854 (python#136027)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@moreal @Pranjal095
pythongh-108765: fix comment about macro definitions in _stat.c post …
afc689a 
…pythonGH-108854 (python#136027)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@moreal @taegyunkim
pythongh-108765: fix comment about macro definitions in _stat.c post …
9ff805e 
…pythonGH-108854 (python#136027)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@moreal @Agent-Hellboy
pythongh-108765: fix comment about macro definitions in _stat.c post …
7243f39 
…pythonGH-108854 (python#136027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.