GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 by moreal · Pull Request #136027 · python/cpython

Conversation

@moreal

@moreal moreal commented Jun 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This pull request only fixes a typo in the _stat.c file.

Since #108854, the definitions of S_ISDIR(), S_ISREG() and S_ISCHR(), as well as the part that includes sys/stat.h, have moved from Include/pyport.h to Include/fileutils.h. However the comment in Modules/_stat.c still refers to Include/pyport.h so this pull request fixes it.

As note, I didn't create and add an issue number because I think it is a trivial change. In the same context, I didn't think it was necessary to add NEWS as well.

  • Issue: C API: Cleanup header files #108765

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting review label Jun 27, 2025
@python-cla-bot

python-cla-bot Bot commented Jun 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

This comment was marked as resolved.

Sign in to view
@moreal moreal changed the title Fix staled comments in _stat.c Update a comment in _stat.c to latest Jun 27, 2025
@moreal
moreal force-pushed the fix-staled-comments branch from f0cfe18 to 1fe7601 Compare June 27, 2025 10:44
@bedevere-app

This comment was marked as resolved.

Sign in to view
@StanFromIreland StanFromIreland added skip news skip issue labels Jun 27, 2025
@moreal
Update a commment in _stat.c to latest
88aeb4b
@moreal
moreal force-pushed the fix-staled-comments branch from 1fe7601 to 88aeb4b Compare June 27, 2025 14:49
picnixz
picnixz approved these changes Jun 27, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 27, 2025
@picnixz picnixz changed the title Update a comment in _stat.c to latest gh-108765: fix comment about macro definitions in _stat.c Jun 27, 2025
@picnixz picnixz removed the skip issue label Jun 27, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2025
C API: Cleanup header files #108765
Closed
@picnixz picnixz changed the title gh-108765: fix comment about macro definitions in _stat.c gh-108765: fix comment about macro definitions in _stat.c post GH-108854 Jun 27, 2025
@picnixz

picnixz commented Jun 27, 2025

Copy link
Copy Markdown
Member

@StanFromIreland In general, if the PR amends a previous PR, we can reuse the issue number of that PR (if there is one).
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz enabled auto-merge (squash) June 27, 2025 14:53
@picnixz picnixz added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 27, 2025
@StanFromIreland

StanFromIreland commented Jun 27, 2025

Copy link
Copy Markdown
Member

I was considering that, I hesitated for a few minutes before applying the label...

My reasoning was, the issue was quite broad and would not add much, but I guess it is good to do so anyway. I will do so in the future!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Jun 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For such PRs I usually add "post GH-*" in the title so that one can click on it as well.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz merged commit 0141e7f into python:main Jun 27, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

Thanks @moreal for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 27, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@moreal @miss-islington
pythongh-108765: fix comment about macro definitions in _stat.c post …
94ead81 
…pythonGH-108854 (pythonGH-136027)

(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

GH-136043 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@moreal @miss-islington
pythongh-108765: fix comment about macro definitions in _stat.c post …
73da079 
…pythonGH-108854 (pythonGH-136027)

(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 27, 2025
@bedevere-app

bedevere-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

GH-136044 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 27, 2025
picnixz pushed a commit that referenced this pull request Jun 27, 2025
@miss-islington @moreal
[3.13] gh-108765: fix comment about macro definitions in _stat.c post
ad1b0c9 
GH-108854 (GH-136027) (#136044)

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 (GH-136027)
(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
picnixz pushed a commit that referenced this pull request Jun 27, 2025
@miss-islington @moreal
[3.14] gh-108765: fix comment about macro definitions in _stat.c post
eff347c 
GH-108854 (GH-136027) (#136043)

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 (GH-136027)
(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <[email protected]>
@ZeroIntensity ZeroIntensity mentioned this pull request Jun 27, 2025
gh-67341: fix comment about windows link stat mapping #136049
Merged
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@moreal @AndPuQing
pythongh-108765: fix comment about macro definitions in _stat.c post …
dd67d75 
…pythonGH-108854 (python#136027)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@moreal @Pranjal095
pythongh-108765: fix comment about macro definitions in _stat.c post …
afc689a 
…pythonGH-108854 (python#136027)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@moreal @taegyunkim
pythongh-108765: fix comment about macro definitions in _stat.c post …
9ff805e 
…pythonGH-108854 (python#136027)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@moreal @Agent-Hellboy
pythongh-108765: fix comment about macro definitions in _stat.c post …
7243f39 
…pythonGH-108854 (python#136027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@moreal @picnixz @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.