GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108303: Fix and move `badsyntax_pep3120.py` by sobolevn · Pull Request #109513 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 17, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When creating tokenizedata/ I've missed this file. Fixing this now.

Also:

  • Fixed paths in .ruff.toml, because I moved some files
  • Remove misleading comment about VCS, because it is not marked as binary in .gitattributes
  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-108303: Fix and move badsyntax_pep3120.py
596023b
@sobolevn
sobolevn requested a review from vstinner September 17, 2023 10:04
@sobolevn
sobolevn requested review from AlexWaygood and hugovk as code owners September 17, 2023 10:04
@bedevere-app bedevere-app Bot added the awaiting review label Sep 17, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 17, 2023
Move test files into test subdirectories #108303
Closed
AlexWaygood
AlexWaygood reviewed Sep 17, 2023
View reviewed changes
Comment thread Lib/test/.ruff.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/.ruff.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the skip news label Sep 17, 2023
@sobolevn
ABCDEF sort
4f84436
hugovk
hugovk reviewed Sep 17, 2023
View reviewed changes
Comment thread Lib/test/.ruff.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood previously approved these changes Sep 17, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 17, 2023
@AlexWaygood
AlexWaygood dismissed their stale review September 17, 2023 10:50

Reviewed too soon, let's find consensus on the ruff config

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting core review labels Sep 17, 2023
@sobolevn
Address review
c2a4add
AlexWaygood
AlexWaygood reviewed Sep 17, 2023
View reviewed changes
Comment thread Lib/test/.ruff.toml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn @AlexWaygood
Update Lib/test/.ruff.toml
3986284 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Sep 17, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 17, 2023
@AlexWaygood
AlexWaygood requested a review from hugovk September 17, 2023 12:40
hugovk
hugovk approved these changes Sep 17, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk mentioned this pull request Sep 17, 2023
Patchcheck tmp2 AA-Turner/cpython#14
Closed
vstinner
vstinner approved these changes Sep 18, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
AlexWaygood merged commit 4dd47c6 into python:main Sep 18, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 18, 2023
@vstinner

vstinner commented Sep 18, 2023

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood merged commit 4dd47c6

Oh! I was merged this PR while you merged it :-)
AlexWaygood reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Sep 18, 2023

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood merged commit 4dd47c6

Oh! I was merged this PR while you merged it :-)

Too slow ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 18, 2023

Copy link
Copy Markdown
Member

Too slow ;-)

Working in the train today, Internet is not great :-(
AlexWaygood reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4dd47c63a97b3c39cd964ad12431fcdaf76dc823 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned AlexWaygood Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4dd47c63a97b3c39cd964ad12431fcdaf76dc823 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member

Oh, backport this change needs to wait until PR #109314 is backported to 3.11 and 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 22, 2023
@sobolevn
[3.11] pythongh-108303: Fix and move badsyntax_pep3120.py (pythonGH…
b248118 
…-109513)

Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 4dd47c6)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109724 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
@AlexWaygood AlexWaygood removed their assignment Sep 22, 2023
vstinner pushed a commit that referenced this pull request Sep 22, 2023
@sobolevn
[3.11] gh-108303: Fix and move badsyntax_pep3120.py (GH-109513) (#1…
6bb18bb 
…09724)

* [3.11] gh-108303: Fix and move `badsyntax_pep3120.py` (GH-109513)

Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 4dd47c6)

Backport to 3.11: update also test_imp.

Co-authored-by: Nikita Sobolev <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@sobolevn @AlexWaygood @csm10495
pythongh-108303: Fix and move badsyntax_pep3120.py (python#109513)
3394750 
Co-authored-by: Alex Waygood <[email protected]>
hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 25, 2025
@sobolevn @AlexWaygood @hugovk
[3.12] pythongh-108303: Fix and move badsyntax_pep3120.py (pythonGH…
dad2fb7 
…-109513)

(cherry picked from commit 4dd47c6)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130540 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 25, 2025
hugovk added a commit that referenced this pull request Feb 26, 2025
@hugovk @sobolevn @AlexWaygood
[3.12] gh-108303: Fix and move badsyntax_pep3120.py (GH-109513) (#1…
e280976 
…30540)

(cherry picked from commit 4dd47c6)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hugovk hugovk hugovk approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @vstinner @AlexWaygood @miss-islington @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.