GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-108303: Fix and move `badsyntax_pep3120.py` (GH-109513) by sobolevn · Pull Request #109724 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 22, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 4dd47c6)

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
[3.11] pythongh-108303: Fix and move badsyntax_pep3120.py (pythonGH…
b248118 
…-109513)

Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 4dd47c6)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
sobolevn requested a review from vstinner September 22, 2023 12:22
@sobolevn
sobolevn requested review from AlexWaygood and hugovk as code owners September 22, 2023 12:22
@bedevere-app bedevere-app Bot added the awaiting review label Sep 22, 2023
This was referenced Sep 22, 2023
Move test files into test subdirectories #108303
Closed
gh-108303: Fix and move badsyntax_pep3120.py #109513
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 22, 2023
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member

Tests fail:

ERROR: test_find_module_encoding (test.test_imp.ImportTests.test_find_module_encoding)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_imp.py", line 83, in test_find_module_encoding
    imp.find_module('badsyntax_pep3120', path)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/imp.py", line 297, in find_module
    raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named 'badsyntax_pep3120'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Fix test_imp
64e29bf
@sobolevn

sobolevn commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

test_imp is missing in 3.12 and 3.13, fixed 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

There's still three failures that survive re-runs:

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)
FAIL: test_get_recursion_depth (test.test_support.TestSupport.test_get_recursion_depth)
 ERROR: test_recursion (test.test_support.TestSupport.test_recursion)

All are about exceeded recursion limits.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Sep 22, 2023

Copy link
Copy Markdown
Member

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)

That one's been failing on the 3.11 branch for a while now, I think, FWIW. Don't know about the others.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member

ERROR: test_inline_table_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_table_recursion_limit) (limit=137, available=99, nest_count=32)
FAIL: test_get_recursion_depth (test.test_support.TestSupport.test_get_recursion_depth)
ERROR: test_recursion (test.test_support.TestSupport.test_recursion)

Sadly, these ones are regressions when I fixed a RecursionError :-( See issue GH-108851.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 6bb18bb into python:3.11 Sep 22, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @vstinner @ambv @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.