GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109413 Improve the mypy config file for libregrtest by AlexWaygood · Pull Request #109518 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Sep 17, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Set explicit_package_bases = True in the config file. This means that mypy can now be run on libregrtest from the repo root, rather than having to cd into the Lib/test directory. You can now invoke mypy by running mypy --config-file Lib/test/libregrtest/mypy.ini.
  • Consolidate all of the packages we're ignoring missing import from into one section, rather than having a separate section for each one.
  • Only disable --strict-optional for the specific submodules that currently have strict-optional errors in them.

Cc. @vstinner

  • Issue: libregrtest: Improve type hints; explore running mypy in CI #109413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Improve the mypy config file for libregrtest
2d705a1
@AlexWaygood
AlexWaygood requested a review from hauntsaninja September 17, 2023 16:12
@bedevere-app bedevere-app Bot added the awaiting review label Sep 17, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 17, 2023
libregrtest: Improve type hints; explore running mypy in CI #109413
Closed
@AlexWaygood AlexWaygood added the skip news label Sep 17, 2023
@AlexWaygood AlexWaygood mentioned this pull request Sep 17, 2023
gh-109413: Add a custom script for running mypy on libregrtest #109464
Closed
hauntsaninja
hauntsaninja approved these changes Sep 18, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 18, 2023
@hauntsaninja
hauntsaninja merged commit 54fbfa8 into python:main Sep 18, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 18, 2023
@AlexWaygood
AlexWaygood deleted the libregrtest-mypy-config branch September 18, 2023 00:48
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 18, 2023
@AlexWaygood
Updates now python#109518 is merged
1806074
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AlexWaygood @csm10495
pythongh-109413: Improve mypy config for libregrtest (python#109518)
ea912a6 
Improve the mypy config file for libregrtest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.