GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) by miss-islington · Pull Request #109683 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 21, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev [email protected]

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @miss-islington
pythongh-108303: Move all certificates to Lib/test/certdata/ (pytho…
7e99261 
…nGH-109489)

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington
miss-islington requested review from a team, 1st1, asvetlov and vsajip as code owners September 21, 2023 19:05
@bedevere-app bedevere-app Bot added the awaiting review label Sep 21, 2023
This was referenced Sep 21, 2023
Move test files into test subdirectories #108303
Closed
gh-108303: Move all certificates to Lib/test/certdata/ #109489
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 21, 2023
@vstinner
vstinner enabled auto-merge (squash) September 21, 2023 19:06
@vstinner

vstinner commented Sep 29, 2023

Copy link
Copy Markdown
Member

@sobolevn: Oh, there is now a conflict on this backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

All CI tests on test_nntplib. I clicked on re-run failed tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

@sobolevn: Oh, there is now a merge conflict. Maybe this change should be backported manually. Can you create a PR for Python 3.11?

The Python 3.12 backport doesn't seem to be affected: PR #109682.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 10, 2023

Copy link
Copy Markdown
Member

I created PR #110646 which includes @sobolevn's fix for test_nntplib.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Oct 10, 2023
auto-merge was automatically disabled October 10, 2023 20:39

Pull request was closed

@miss-islington
miss-islington deleted the backport-e57ecf6-3.11 branch October 10, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.