GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108303: Move all certificates to `Lib/test/certdata/` by sobolevn · Pull Request #109489 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a big one: I moved all .pem and ssl related files to a single test helper diractory:

» tree Lib/test/certdata 
Lib/test/certdata
├── allsans.pem
├── badcert.pem
├── badkey.pem
├── capath
│   ├── 4e1295a3.0
│   ├── 5ed36f99.0
│   ├── 6e88d7b8.0
│   ├── 99d0fa06.0
│   ├── b1930218.0
│   └── ceff1710.0
├── ffdh3072.pem
├── idnsans.pem
├── keycert.passwd.pem
├── keycert.pem
├── keycert2.pem
├── keycert3.pem
├── keycert4.pem
├── keycertecc.pem
├── make_ssl_certs.py
├── nokia.pem
├── nosan.pem
├── nullbytecert.pem
├── nullcert.pem
├── pycacert.pem
├── pycakey.pem
├── revocation.crl
├── secp384r1.pem
├── selfsigned_pythontestdotnet.pem
├── ssl_cert.pem
├── ssl_key.passwd.pem
├── ssl_key.pem
└── talos-2019-0758.pem

I haven't touched their contents or permissions (at least I hope so), so let's what the CI will say :)

I've also checked that Lib/test/certdata/make_ssl_certs.py script still works. It produces new certificates as it should.

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
sobolevn requested a review from vstinner September 16, 2023 12:25
@sobolevn
sobolevn requested review from a team, 1st1, asvetlov, gvanrossum, kumaraditya303, vsajip and willingc as code owners September 16, 2023 12:25
@bedevere-app bedevere-app Bot added the awaiting review label Sep 16, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 16, 2023
Move test files into test subdirectories #108303
Closed
@sobolevn sobolevn added the skip news label Sep 16, 2023
@sobolevn

sobolevn commented Sep 16, 2023

Copy link
Copy Markdown
Member Author

Aaaand it broke :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
pythongh-108303: Move all certificates to Lib/test/certdata/
8ae8733
@sobolevn
sobolevn force-pushed the issue-108303-certs branch from 0068ea7 to 8ae8733 Compare September 16, 2023 13:26
@sobolevn
Fix test_socketserver on Windows
15921b3
@vstinner
vstinner merged commit e57ecf6 into python:main Sep 16, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 16, 2023
@vstinner

vstinner commented Sep 16, 2023

Copy link
Copy Markdown
Member

LGTM, merged, thanks @sobolevn :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the needs backport to 3.12 only security fixes label Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2023
@sobolevn @miss-islington
pythongh-108303: Move all certificates to Lib/test/certdata/ (pytho…
613a540 
…nGH-109489)

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 21, 2023

Copy link
Copy Markdown

GH-109682 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 21, 2023
@vstinner vstinner added the needs backport to 3.11 only security fixes label Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2023
@sobolevn @miss-islington
pythongh-108303: Move all certificates to Lib/test/certdata/ (pytho…
7e99261 
…nGH-109489)

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 21, 2023

Copy link
Copy Markdown

GH-109683 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 21, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@sobolevn @csm10495
pythongh-108303: Move all certificates to Lib/test/certdata/ (pytho…
0174f87 
…n#109489)
vstinner pushed a commit that referenced this pull request Oct 10, 2023
@miss-islington @sobolevn @Yhg1s
[3.12] gh-108303: Move all certificates to Lib/test/certdata/ (GH-1…
c2d542b 
…09489) (#109682)

* gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489)
(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>

Python 3.12 backport: update also `test_nntplib`.

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
@miss-islington miss-islington mentioned this pull request Oct 10, 2023
[3.11] [3.12] gh-108303: Move all certificates to Lib/test/certdata/ (GH-109489) (GH-109682) #110646
Merged
miss-islington added a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
@miss-islington @sobolevn @Yhg1s
[3.12] pythongh-108303: Move all certificates to Lib/test/certdata/ (…
bbd4bd9 
…pythonGH-109489) (pythonGH-109682)

* pythongh-108303: Move all certificates to `Lib/test/certdata/` (pythonGH-109489)
(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>

Python 3.12 backport: update also `test_nntplib`.

(cherry picked from commit c2d542b)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
vstinner pushed a commit that referenced this pull request Oct 10, 2023
@miss-islington @sobolevn @Yhg1s
[3.11] [3.12] gh-108303: Move all certificates to Lib/test/certdata/ (
28c6cc1 
GH-109489) (GH-109682) (#110646)

[3.12] gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (GH-109682)

* gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489)
(cherry picked from commit e57ecf6)

Python 3.12 backport: update also `test_nntplib`.

(cherry picked from commit c2d542b)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @vstinner @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.