GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.12] gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) by miss-islington · Pull Request #109682 · python/cpython

Conversation

miss-islington commented Sep 21, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev [email protected]

Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-108303: Move all certificates to Lib/test/certdata/ (pytho…

613a540

…nGH-109489)

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>

miss-islington requested review from a team, 1st1, asvetlov, gvanrossum, kumaraditya303, vsajip and willingc as code owners

September 21, 2023 18:50

bedevere-app Bot added the awaiting review label

Sep 21, 2023

bedevere-app Bot mentioned this pull request

Sep 21, 2023

Move test files into test subdirectories #108303

Closed

bedevere-app Bot added the skip news label

Sep 21, 2023

bedevere-app Bot mentioned this pull request

Sep 21, 2023

gh-108303: Move all certificates to Lib/test/certdata/ #109489

Merged

vstinner approved these changes

Sep 21, 2023

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting core review and removed awaiting review labels

Sep 21, 2023

gvanrossum commented Sep 21, 2023

Copy link

Copy Markdown

Member

Is it really a good idea to backport moving files around?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Sep 21, 2023

Copy link

Copy Markdown

Member

@gvanrossum:

Is it really a good idea to backport moving files around?

I didn't want to backport these changes, but I was asked to backport them. See the discussion: #108303 (comment)

gvanrossum reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Yhg1s added 4 commits

October 2, 2023 17:14


          Merge branch '3.12' into backport-e57ecf6-3.12

4b2abee


          Merge branch '3.12' into backport-e57ecf6-3.12

e591ab4


          Merge branch '3.12' into backport-e57ecf6-3.12

721b213


          Merge branch '3.12' into backport-e57ecf6-3.12

840110e

vstinner commented Oct 4, 2023

Copy link

Copy Markdown

Member

ERROR: test_starttls (test.test_nntplib.LocalServerTests.test_starttls)

Oh, all CIs failed on test_nntplib. I clicked on re-run failed jobs.

cc @sobolevn

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner mentioned this pull request

Oct 4, 2023

[3.11] gh-108303: Move all certificates to Lib/test/certdata/ (GH-109489) #109683

Closed


          Fix test of removed test_nntplib

758a588

sobolevn commented Oct 9, 2023

Copy link

Copy Markdown

Member

@vstinner I fixed test_nntplib, it was removed in 3.13, so there was a difference.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn commented Oct 9, 2023

Copy link

Copy Markdown

Member

Done! It works.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner merged commit c2d542b into python:3.12

Oct 10, 2023

bedevere-app Bot removed the awaiting core review label

Oct 10, 2023

miss-islington deleted the backport-e57ecf6-3.12 branch

October 10, 2023 20:38

vstinner added the needs backport to 3.11 only security fixes label

Oct 10, 2023

miss-islington commented Oct 10, 2023

Copy link

Copy Markdown

Contributor Author

Thanks @miss-islington for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Oct 10, 2023

Copy link

Copy Markdown

GH-110646 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Oct 10, 2023

miss-islington added a commit to miss-islington/cpython that referenced this pull request

Oct 10, 2023


          [3.12] pythongh-108303: Move all certificates to Lib/test/certdata/ (…

bbd4bd9

…pythonGH-109489) (pythonGH-109682)

* pythongh-108303: Move all certificates to `Lib/test/certdata/` (pythonGH-109489)
(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <[email protected]>

Python 3.12 backport: update also `test_nntplib`.

(cherry picked from commit c2d542b)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: T. Wouters <[email protected]>

vstinner pushed a commit that referenced this pull request

Oct 10, 2023


          [3.11] [3.12] gh-108303: Move all certificates to Lib/test/certdata/ (

28c6cc1

GH-109489) (GH-109682) (#110646)

[3.12] gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (GH-109682)

* gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489)
(cherry picked from commit e57ecf6)

Python 3.12 backport: update also `test_nntplib`.

(cherry picked from commit c2d542b)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: T. Wouters <[email protected]>

Reviewers

vstinner

vstinner approved these changes

vsajip

Awaiting requested review from vsajip

vsajip is a code owner

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

gvanrossum

Awaiting requested review from gvanrossum

gvanrossum is a code owner

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

miss-islington commented Sep 21, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum commented Sep 21, 2023

Uh oh!

vstinner commented Sep 21, 2023

Uh oh!

vstinner commented Oct 4, 2023

Uh oh!

sobolevn commented Oct 9, 2023

Uh oh!

sobolevn commented Oct 9, 2023

Uh oh!

miss-islington commented Oct 10, 2023

Uh oh!

bedevere-app Bot commented Oct 10, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miss-islington commented Sep 21, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.