GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-109098: Fuzz re module instead of internal sre by ammaraskar · Pull Request #109911 · python/cpython

Conversation

ammaraskar commented Sep 26, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This should get the deprecation warning out and switch the fuzzer to using the public API

Issue: test_xxtestfuzz emits DeprecationWarning #109098

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added the awaiting review label

Sep 26, 2023

bedevere-app Bot mentioned this pull request

Sep 26, 2023

test_xxtestfuzz emits DeprecationWarning #109098

Closed

ammaraskar added the skip news label

Sep 26, 2023


          pythongh-109098: Fuzz re module instead of internal sre

1e562d7

ammaraskar force-pushed the re_fuzzer_fix branch from be5233d to 1e562d7 Compare

September 26, 2023 17:55

ammaraskar requested review from gpshead and serhiy-storchaka

September 26, 2023 17:56


          Fix c-analyzer globals test failure

0970b63

gpshead approved these changes

Sep 26, 2023

View reviewed changes

bedevere-app Bot added awaiting core review and removed awaiting review labels

Sep 26, 2023

gpshead enabled auto-merge (squash)

September 26, 2023 18:20

serhiy-storchaka reviewed

Sep 26, 2023

View reviewed changes

Comment thread

Tools/c-analyzer/cpython/_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

gpshead disabled auto-merge

September 26, 2023 18:57


          Put globals exception in ignored.tsv

d57f3f3

serhiy-storchaka approved these changes

Sep 26, 2023

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead reacted with heart emoji

All reactions

❤️ 1 reaction

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12

only security fixes

awaiting merge and removed awaiting core review labels

Sep 26, 2023

gpshead merged commit a829356 into python:main

Sep 26, 2023

miss-islington commented Sep 26, 2023

Copy link

Copy Markdown

Contributor

Thanks @ammaraskar for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Sep 26, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 26, 2023


          pythongh-109098: Fuzz re module instead of internal sre (pythonGH-109911

9577d79

)

* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 26, 2023


          pythongh-109098: Fuzz re module instead of internal sre (pythonGH-109911

7d9a97d

)

* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>

bedevere-app Bot commented Sep 26, 2023

Copy link

Copy Markdown

GH-109932 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Sep 26, 2023

bedevere-app Bot commented Sep 26, 2023

Copy link

Copy Markdown

GH-109933 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Sep 26, 2023

serhiy-storchaka pushed a commit that referenced this pull request

Sep 27, 2023


          [3.11] gh-109098: Fuzz re module instead of internal sre (GH-109911) (G…

8ed9bda

…H-109933)

* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>

csm10495 pushed a commit to csm10495/cpython that referenced this pull request

Sep 28, 2023


          pythongh-109098: Fuzz re module instead of internal sre (python#109911)

6608db3

* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv

Yhg1s pushed a commit that referenced this pull request

Oct 2, 2023


          [3.12] gh-109098: Fuzz re module instead of internal sre (GH-109911) (#…

95fd4ed

…109932)

gh-109098: Fuzz re module instead of internal sre (GH-109911)

* gh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv
(cherry picked from commit a829356)

Co-authored-by: Ammar Askar <[email protected]>

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-109098: Fuzz re module instead of internal sre (python#109911)

c526a73

* pythongh-109098: Fuzz re module instead of internal sre
* Fix c-analyzer globals test failure
* Put globals exception in ignored.tsv

Reviewers

gpshead

gpshead approved these changes

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ammaraskar commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Sep 26, 2023

Uh oh!

bedevere-app Bot commented Sep 26, 2023

Uh oh!

bedevere-app Bot commented Sep 26, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ammaraskar commented Sep 26, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.