GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76785: Module-level Fixes for test.support.interpreters by ericsnowcurrently · Pull Request #110236 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 2, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • add RecvChannel.close() and SendChannel.close()
  • make RecvChannel and SendChannel shareable
  • expose ChannelEmptyError and ChannelNotEmptyError
  • Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 8 commits September 29, 2023 16:45
@ericsnowcurrently
Add RecvChannel.close() and SendChannel.close().
e958fbc
@ericsnowcurrently
Expose additional exception types.
74b3003
@ericsnowcurrently
Call _channels._channel_id() in _ChannelEnd.__init__().
e424ab5
@ericsnowcurrently
Factor out _get_current_module_state().
90d024d
@ericsnowcurrently
Make RecvChannel and SendChannel shareable.
996596b
@ericsnowcurrently
Import the interpreters module if needed.
56fec10
@ericsnowcurrently
Use _get_current_channel_end_type() in _channel_from_cid().
b3f29ce
@ericsnowcurrently
Add tests.
cac4a76
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 2, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Oct 2, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 2, 2023
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) October 2, 2023 19:43
@ericsnowcurrently
Fix _ChannelEnd.__init__().
a8f6e5e
@ericsnowcurrently
ericsnowcurrently merged commit a8f5dab into python:main Oct 2, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 2, 2023
@ericsnowcurrently
ericsnowcurrently deleted the channel-fix-module branch October 2, 2023 21:17
@vstinner

vstinner commented Oct 3, 2023

Copy link
Copy Markdown
Member

This change introduced a reference leak: #110300
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

Any backport of this needs to include the changes from gh-110318.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-76785: Module-level Fixes for test.support.interpreters (pyt…
2bc154f 
…hongh-110236)

* add RecvChannel.close() and SendChannel.close()
* make RecvChannel and SendChannel shareable
* expose ChannelEmptyError and ChannelNotEmptyError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.