GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels by ericsnowcurrently · Pull Request #110318 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 3, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test__xxinterpchannels leaks [21, 21, 21] references #110300

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ericsnowcurrently added 4 commits October 3, 2023 15:41
@ericsnowcurrently
Add a missing decref.
fbbebfd
@ericsnowcurrently
Add more missing decrefs.
8bfdf89
@ericsnowcurrently
Decref after get_module_from_owned_type().
47a2bf6
@ericsnowcurrently
Stop leaking file descriptors.
b291931
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 3, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Oct 3, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 3, 2023
test__xxinterpchannels leaks [21, 21, 21] references #110300
Closed
@ericsnowcurrently ericsnowcurrently added 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section and removed awaiting review labels Oct 3, 2023
@bedevere-bot

bedevere-bot commented Oct 3, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit b291931 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 3, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 3, 2023
gh-110266: Fix "get_module_from_owned_type is unused" warning #110269
Closed
ericsnowcurrently added 2 commits October 3, 2023 17:38
@ericsnowcurrently
Merge branch 'main' into fix-refleaks
009aa91
@ericsnowcurrently
Temporarily drop the _register_end_types() call.
bb7e4e0
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) October 3, 2023 23:47
@ericsnowcurrently
Temporarily skip a failing test.
2462033
@ericsnowcurrently
ericsnowcurrently merged commit 269005e into python:main Oct 4, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-refleaks branch October 4, 2023 01:05
@bedevere-bot

bedevere-bot commented Oct 4, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.x has failed when building commit 269005e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/402/builds/5555) and take a look at the build logs.
  4. Check if the failure is related to this commit (269005e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/402/builds/5555

Failed tests:

  • test_tools

Failed subtests:

  • test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script
    executable = helper.freeze(python, scriptfile, outdir)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 165, in freeze
    _run_quiet([MAKE, '-C', os.path.dirname(scriptfile)])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 33, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/test_python_abgk80sv/tmpomb679z8']' returned non-zero exit status 2.


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/test/test_tools/test_freeze.py", line 33, in test_freeze_simple_script
    executable = helper.freeze(python, scriptfile, outdir)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 165, in freeze
    _run_quiet([MAKE, '-C', os.path.dirname(scriptfile)])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line 33, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/test_python_wd2pi5d7/tmpxc5n37vd']' returned non-zero exit status 2.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 4, 2023
gh-76785: Module-level Fixes for test.support.interpreters #110236
Merged
gh-76785: Make interpreters.*Channel Objects Shareable #110607
Merged
ericsnowcurrently added a commit that referenced this pull request Oct 19, 2023
@ericsnowcurrently
gh-76785: Make interpreters.*Channel Objects Shareable (gh-110607)
d23a2f9
This restores their shareability, which was disabled by gh-110318 due to ref leaks.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 28, 2023
[3.12] gh-105716: Fix "Refleak" Failures in test_interpreters #112500
Merged
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ericsnowcurrently @aisk
pythongh-76785: Make interpreters.*Channel Objects Shareable (pythong…
4767753
…h-110607)

This restores their shareability, which was disabled by pythongh-110318 due to ref leaks.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-110300: Fix Refleaks in test_interpreters and test__xxinterp…
4e072be
…channels (pythongh-110318)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-76785: Make interpreters.*Channel Objects Shareable (pythong…
efdf6f7
…h-110607)

This restores their shareability, which was disabled by pythongh-110318 due to ref leaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.