GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove unused Misc/requirements-test.txt by hugovk · Pull Request #110240 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 2, 2023

Copy link
Copy Markdown
Member

In 2020, PR #19909 added Misc/requirements-test.txt and installed it as part of .github/workflows/coverage.yml and .travis.yml.

In 2021, however, PRs #25679 and #30257 removed those CI files, so Misc/requirements-test.txt is unused.

Let's remove it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
Remove unused Misc/requirements-test.txt
2269ab3
@bedevere-app bedevere-app Bot added the awaiting review label Oct 2, 2023
This was referenced Oct 2, 2023
bpo-43888: Remove coverage builds from CI #25679
Merged
Consider testing zoneinfo with tzdata PyPI package installed #99649
Closed
AA-Turner
AA-Turner approved these changes Oct 2, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 2, 2023
vstinner
vstinner approved these changes Oct 2, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk hugovk added skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 3, 2023
@hugovk
hugovk merged commit 1001233 into python:main Oct 3, 2023
@hugovk
hugovk deleted the rm-requirements-test.txt branch October 3, 2023 05:01
@miss-islington

miss-islington commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 3, 2023
@bedevere-app

bedevere-app Bot commented Oct 3, 2023

Copy link
Copy Markdown

GH-110253 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
@hugovk @miss-islington
Remove unused Misc/requirements-test.txt (pythonGH-110240)
cb875ed
(cherry picked from commit 1001233)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 3, 2023
@bedevere-app

bedevere-app Bot commented Oct 3, 2023

Copy link
Copy Markdown

GH-110254 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
@hugovk @miss-islington
Remove unused Misc/requirements-test.txt (pythonGH-110240)
f6efc2f
(cherry picked from commit 1001233)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Oct 3, 2023
@miss-islington @hugovk
[3.12] Remove unused Misc/requirements-test.txt (GH-110240) (#110253)
b0b9b91
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Oct 3, 2023
@miss-islington @hugovk
[3.11] Remove unused Misc/requirements-test.txt (GH-110240) (#110254)
0c6ae62
Co-authored-by: Hugo van Kemenade <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hugovk @Glyphack
Remove unused Misc/requirements-test.txt (python#110240)
3e7ed66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @miss-islington @vstinner @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.