GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105716: Support Background Threads in Subinterpreters Consistently (gh-109921) by ericsnowcurrently · Pull Request #110707 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The existence of background threads running on a subinterpreter was preventing interpreters from getting properly destroyed, as well as impacting the ability to run the interpreter again. It also affected how we wait for non-daemon threads to finish.

We add PyInterpreterState.threads.main, with some internal C-API functions.

(cherry-picked from commit 1dd9dee)

  • Issue: _xxsubinterpreters.run_string() doesn't allow subthreads to be running still #105716

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
[3.12] pythongh-105716: Support Background Threads in Subinterpreters…
e19af2c 
… Consistently (pythongh-109921)

The existence of background threads running on a subinterpreter was preventing interpreters from getting properly destroyed, as well as impacting the ability to run the interpreter again. It also affected how we wait for non-daemon threads to finish.

We add PyInterpreterState.threads.main, with some internal C-API functions.

(cherry-picked from commit 1dd9dee)
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
This was referenced Oct 11, 2023
gh-105716: Support Background Threads in Subinterpreters Consistently #109921
Merged
_xxsubinterpreters.run_string() doesn't allow subthreads to be running still #105716
Closed
@ericsnowcurrently
Update python3.12.abi
90c02ac
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Oct 11, 2023
Yhg1s
Yhg1s reviewed Nov 20, 2023
View reviewed changes
Comment thread Modules/main.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s reviewed Nov 20, 2023
View reviewed changes
Comment thread Include/internal/pycore_interp.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 5 commits November 20, 2023 12:08
@ericsnowcurrently
Move "threads.main" down, for 3.12.0 layout compatibility.
0843fd7
@ericsnowcurrently
Merge branch '3.12' into backport-1dd9dee-subinterpreters-allow-backg…
3d448ba 
…round-threads
@ericsnowcurrently
Update python3.12.abi
fd3e16a
@ericsnowcurrently
Merge branch '3.12' into backport-1dd9dee-subinterpreters-allow-backg…
497a7e6 
…round-threads
@ericsnowcurrently
Update python3.12.abi
78ea3aa
@ericsnowcurrently
ericsnowcurrently merged commit 0122b4d into python:3.12 Nov 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 28, 2023
@ericsnowcurrently
ericsnowcurrently deleted the backport-1dd9dee-subinterpreters-allow-background-threads branch November 28, 2023 02:01
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 28, 2023
[3.12] gh-105716: Fix "Refleak" Failures in test_interpreters #112500
Merged
ericsnowcurrently added a commit that referenced this pull request Nov 28, 2023
@ericsnowcurrently
[3.12] gh-105716: Fix Refleaks in test_interpreters (gh-112500)
5b6858c 
gh-110707 (0122b4d) added some tests that didn't close file descriptors they created, leading to failures on the refleak buildbots.  This closes the leaking file descriptors, resolving the failure.
This was referenced Dec 7, 2023
gh-105716 breaks greenlet/eventlet #112826
Closed
[3.12] gh-112826: Fix the threading Module When _thread is Missing _is_main_interpreter() #112850
Merged
Missing _thread._is_main_interpreter() python-greenlet/greenlet#390
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s left review comments
@pablogsal pablogsal pablogsal left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @Yhg1s @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.