GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105716: Fix "Refleak" Failures in test_interpreters by ericsnowcurrently · Pull Request #112500 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

gh-110707 (0122b4d) added some tests that didn't close file descriptors they created, leading to failures on the refleak buildbots: https://buildbot.python.org/all/#/builders/1137/builds/186. This closes the leaking file descriptors, resolving the failure.

This is sort-of a partial backport of gh-110318 (269005e).

  • Issue: _xxsubinterpreters.run_string() doesn't allow subthreads to be running still #105716

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Close file descriptors in tests.
80206a5
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 28, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 28, 2023
_xxsubinterpreters.run_string() doesn't allow subthreads to be running still #105716
Closed
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Nov 28, 2023
@ericsnowcurrently

ericsnowcurrently commented Nov 28, 2023

Copy link
Copy Markdown
Member Author

I was able to duplicate the leaks locally and verify that this PR fixes them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) November 28, 2023 19:20
@ericsnowcurrently
ericsnowcurrently disabled auto-merge November 28, 2023 19:41
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) November 28, 2023 19:41
@ericsnowcurrently
ericsnowcurrently merged commit 5b6858c into python:3.12 Nov 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 28, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-fdleaks-3.12 branch November 28, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.