GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90815: Fix _PyMem_MimallocEnabled() compiler warning by vstinner · Pull Request #111522 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc).

Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().

  • Issue: Add mimalloc memory allocator #90815

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Oct 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2023
Add mimalloc memory allocator #90815
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2023
@vstinner
vstinner force-pushed the mimalloc branch from e7fb985 to 535a873 Compare October 30, 2023 21:29
@vstinner
pythongh-90815: Fix _PyMem_MimallocEnabled() compiler warning
3835dfc 
Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not
defined (./configure --without-pymalloc).

Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
@vstinner
vstinner force-pushed the mimalloc branch from 535a873 to 3835dfc Compare October 30, 2023 21:30
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

I tested that no warnings is emitted with these 4 configurations:

pyconfigure_debug --with-pymalloc --with-mimalloc && make clean && make
pyconfigure_debug --with-pymalloc --without-mimalloc && make clean && make
pyconfigure_debug --without-pymalloc --with-mimalloc && make clean && make
pyconfigure_debug --without-pymalloc --without-mimalloc && make clean && make

with:

$ alias pyconfigure_debug
alias pyconfigure_debug='./configure --cache-file=../python-config.cache --with-pydebug CFLAGS=-O0 --with-system-expat'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit da4d314 into python:main Oct 30, 2023
@vstinner
vstinner deleted the mimalloc branch October 30, 2023 22:05
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 30, 2023
This was referenced Oct 30, 2023
gh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h #111528
Closed
gh-90815: Add mimalloc memory allocator #109914
Merged
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@vstinner @FullteaR
pythongh-90815: Fix _PyMem_MimallocEnabled() compiler warning (python…
dbc6dc5 
…#111522)

Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not
defined (./configure --without-pymalloc).

Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-90815: Fix _PyMem_MimallocEnabled() compiler warning (python…
0f5c14c 
…#111522)

Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not
defined (./configure --without-pymalloc).

Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-90815: Fix _PyMem_MimallocEnabled() compiler warning (python…
a10503c 
…#111522)

Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not
defined (./configure --without-pymalloc).

Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.