GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h by vstinner · Pull Request #111528 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add mimalloc memory allocator #90815

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Oct 30, 2023
@vstinner
vstinner requested a review from a team as a code owner October 30, 2023 22:07
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2023
Add mimalloc memory allocator #90815
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2023
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

Example of a recent PR, test.pythoninfo of Windows x64 says:

build.WITH_MIMALLOC: No
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 2 commits October 31, 2023 00:33
@vstinner
pythongh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h
75d1414
@vstinner
Fix py_mimalloc_print_stats()
7ff8427
@vstinner
vstinner force-pushed the mimalloc_win branch from fdf28b8 to 7ff8427 Compare October 30, 2023 23:33
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

The build fails on Windows. Example:

obmalloc.obj : error LNK2005: _mi_free already defined in alloc.obj [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

cc @DinoV
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 31, 2023
gh-90815: Add mimalloc memory allocator #109914
Merged
@DinoV

DinoV commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

The build fails on Windows. Example:

obmalloc.obj : error LNK2005: _mi_free already defined in alloc.obj [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

cc @DinoV

I think the issue here is that we're including the files in the Windows build but they're now included via obmalloc.c (this had changed along the way). I'll let the build bots see if #111532 fixes it.
vstinner and stonebig reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 31, 2023

Copy link
Copy Markdown
Member Author

@DinoV wrote the correct fix: #111532
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Oct 31, 2023
@vstinner
vstinner deleted the mimalloc_win branch October 31, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.