GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90815: Exclude mimalloc .c files from Windows build by DinoV · Pull Request #111532 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented Oct 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove mimalloc .c files from Windows build

  • Issue: Add mimalloc memory allocator #90815

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
DinoV requested a review from a team as a code owner October 31, 2023 01:46
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 31, 2023
@DinoV DinoV mentioned this pull request Oct 31, 2023
gh-90815: Define WITH_MIMALLOC macro in PC/pyconfig.h #111528
Closed
@DinoV DinoV added the skip news label Oct 31, 2023
@vstinner

vstinner commented Oct 31, 2023

Copy link
Copy Markdown
Member

There are some compiler warnings: 'fprintf' : format string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'unsigned __int64' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 31, 2023

Copy link
Copy Markdown
Member

Tests pass!
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 changed the title Don't include mimalloc .c's in Windows build gh-90815: Exclude mimalloc .c files from Windows build Oct 31, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 31, 2023
Add mimalloc memory allocator #90815
Closed
vstinner
vstinner approved these changes Oct 31, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Objects/obmalloc.c uses #include "pycore_mimalloc.h", so already includes mimalloc code "statically".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DinoV reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 31, 2023
@vstinner

vstinner commented Oct 31, 2023

Copy link
Copy Markdown
Member

I don't click on "Enable auto-merge", since I would like to see if the warnings are gone ;-)
DinoV reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DinoV added 2 commits October 31, 2023 10:23
@DinoV
Don't include mimalloc .c's in Windows build
b18e713 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@DinoV
Fix warnings on Windows
7894cca
@DinoV
DinoV force-pushed the nogil/mimalloc_windows branch from 846b2af to 7894cca Compare October 31, 2023 17:24
@DinoV
DinoV merged commit c42347d into python:main Oct 31, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 31, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@DinoV @FullteaR
pythongh-90815: Exclude mimalloc .c files from Windows build (python#…
d0de9b6 
…111532)

* Don't include mimalloc .c's in Windows build
* Fix warnings on Windows related to mimalloc
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@DinoV @aisk
pythongh-90815: Exclude mimalloc .c files from Windows build (python#…
51bd65b 
…111532)

* Don't include mimalloc .c's in Windows build
* Fix warnings on Windows related to mimalloc
@DinoV
DinoV deleted the nogil/mimalloc_windows branch May 31, 2024 18:23
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@DinoV @Glyphack
pythongh-90815: Exclude mimalloc .c files from Windows build (python#…
c9f2e7c 
…111532)

* Don't include mimalloc .c's in Windows build
* Fix warnings on Windows related to mimalloc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.