GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109413: Run mypy on `libregrtest` in CI by AlexWaygood · Pull Request #112558 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Nov 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Fix remaining mypy errors
  • Add a CI check to stop typing issues from regressing in the future
  • Issue: libregrtest: Improve type hints; explore running mypy in CI #109413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji erlend-aasland reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction
@AlexWaygood
Run mypy on libregrtest in CI
5d3802f
@AlexWaygood AlexWaygood added the skip news label Nov 30, 2023
@AlexWaygood AlexWaygood changed the title Run mypy on libregrtest in CI gh-109413: Run mypy on libregrtest in CI Nov 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 30, 2023
libregrtest: Improve type hints; explore running mypy in CI #109413
Closed
@AlexWaygood
AlexWaygood marked this pull request as ready for review November 30, 2023 17:44
@AlexWaygood
AlexWaygood requested review from ezio-melotti and hugovk as code owners November 30, 2023 17:44
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 30, 2023
@AlexWaygood
AlexWaygood requested a review from vstinner November 30, 2023 17:44
@AlexWaygood
fixup comment
351a63e
AlexWaygood
AlexWaygood commented Nov 30, 2023
View reviewed changes
Comment thread Lib/test/libregrtest/results.py
self.stats = TestStats()
# used by --junit-xml
self.testsuite_xml: list[str] = []
self.testsuite_xml: list = []

@AlexWaygood AlexWaygood Nov 30, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This annotation is incorrect; leaving it as it is causes mypy to issue 5 or so errors in various places. We should correct the annotation, ideally, but for now making it more vague gets rid of the errors from mypy. I prefer to defer fixing it properly to a future PR, for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk
hugovk approved these changes Nov 30, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the new stuff that mypy doesn't know about, can they be ignored via mypy.ini?

If so, that would be cleaner, no need to temporarily add the extra comments in py files.

Otherwise looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 30, 2023
@AlexWaygood @hugovk
cleanup comments
5160db5 
Co-authored-by: Hugo van Kemenade <[email protected]>
@AlexWaygood

AlexWaygood commented Nov 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

For the new stuff that mypy doesn't know about, can they be ignored via mypy.ini?

If so, that would be cleaner, no need to temporarily add the extra comments in py files.

I don't think so, unfortunately :(

Mypy's config supports ignoring all errors in a file, or ignoring all errors of a certain category in a file. But I don't think there's a config-file option to ignore all errors due to specific functions or parameters not existing, unfortunately :/

(And, to be fair, that comes up more in CPython than elsewhere! We're literally writing the stdlib here, after all 😄)
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Nov 30, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These changes seem reasonable to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@AlexWaygood

AlexWaygood commented Nov 30, 2023

Copy link
Copy Markdown
Member Author

Thanks both!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood merged commit 674c288 into python:main Nov 30, 2023
@AlexWaygood
AlexWaygood deleted the mypy-libregrtest branch November 30, 2023 23:00
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 30, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 1, 2023
@AlexWaygood
[3.12] libregrtest: Backport .py-file changes from python#112558
713b043
@bedevere-app

bedevere-app Bot commented Dec 1, 2023

Copy link
Copy Markdown

GH-112605 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Dec 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

GH-112605 is a backport of this pull request to the 3.12 branch.

(I'm not actually backporting the change to the .yml file; we won't actually be running mypy on the 3.12 branch in CI. This just backports some of the changes to the .py files, to make future backports easier.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 1, 2023

Copy link
Copy Markdown
Member

Thanks for enabling mypy on libregrtest :-)
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood added a commit that referenced this pull request Dec 1, 2023
@AlexWaygood
[3.12] gh-109413: libregrtest: Backport .py-file changes from #112558…
acc62db 
… (#112605)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2023
@AlexWaygood @miss-islington
[3.12] pythongh-109413: libregrtest: Backport .py-file changes from p…
8866dea 
…ythonGH-112558 (pythonGH-112605)

(cherry picked from commit acc62db)

Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood added a commit that referenced this pull request Dec 1, 2023
@miss-islington @AlexWaygood
[3.11] [3.12] gh-109413: libregrtest: Backport .py-file changes from …
720f5bf 
…GH-112558 (GH-112605) (#112607)

[3.12] gh-109413: libregrtest: Backport `.py`-file changes from GH-112558 (GH-112605)
(cherry picked from commit acc62db)

Co-authored-by: Alex Waygood <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood @hugovk @aisk
pythongh-109413: Run mypy on libregrtest in CI (python#112558)
c04b0eb 
Co-authored-by: Hugo van Kemenade <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @hugovk @Glyphack
pythongh-109413: Run mypy on libregrtest in CI (python#112558)
8d89410 
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @vstinner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.