GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (#112586) by AlexWaygood · Pull Request #112602 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Dec 1, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry-picked from commit 70a38ff )

Note: I'm deliberately backporting the entire mypy config file to the 3.12 branch, even though we don't run mypy on libregrtest on the 3.12 branch. Having the config file exist on this branch will make future backports easier, even if the file is never actually used on this branch.

  • Issue: libregrtest: Improve type hints; explore running mypy in CI #109413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood @vstinner
pythongh-109413: libregrtest: enable mypy's --strict-optional check…
26306e4 
… on most files (python#112586)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot added the skip news label Dec 1, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2023
gh-109413: libregrtest: enable mypy's --strict-optional check on most files #112586
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 1, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2023
libregrtest: Improve type hints; explore running mypy in CI #109413
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Dec 1, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) December 1, 2023 16:47
vstinner
vstinner approved these changes Dec 1, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 1, 2023
@AlexWaygood
AlexWaygood merged commit 36dbebe into python:3.12 Dec 1, 2023
@AlexWaygood
AlexWaygood deleted the backport-112586-312 branch December 1, 2023 17:13
@miss-islington-app

miss-islington-app Bot commented Dec 1, 2023

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 1, 2023
@bedevere-app

bedevere-app Bot commented Dec 1, 2023

Copy link
Copy Markdown

GH-112603 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2023
@AlexWaygood @vstinner @miss-islington
[3.12] pythongh-109413: libregrtest: enable mypy's `--strict-optional…
f4d2bdd 
…` check on most files (pythonGH-112586) (pythonGH-112602)

pythongh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (pythonGH-112586)

(cherry picked from commit 36dbebe)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Dec 1, 2023
AlexWaygood added a commit that referenced this pull request Dec 1, 2023
@miss-islington @AlexWaygood @vstinner
[3.11] [3.12] gh-109413: libregrtest: enable mypy's `--strict-optiona…
da33204 
…l` check on most files (GH-112586) (GH-112602) (#112603)

[3.12] gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586) (GH-112602)

gh-109413: libregrtest: enable mypy's `--strict-optional` check on most files (GH-112586)

(cherry picked from commit 36dbebe)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.