GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99180: Remove traceback anchors in return and assign statements that cover all the displayed range by pablogsal · Pull Request #112670 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Dec 3, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Elide uninformative traceback indicators in return and simple assignment statements #99180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested a review from iritkatriel as a code owner December 3, 2023 18:12
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 3, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 3, 2023
Elide uninformative traceback indicators in return and simple assignment statements #99180
Closed
@pablogsal
pablogsal force-pushed the gh-99180 branch 3 times, most recently from bb342a0 to 6e941e1 Compare December 3, 2023 18:22
AlexWaygood
AlexWaygood reviewed Dec 3, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some minor typos:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal requested a review from lysnikolaou January 8, 2024 15:12
@pablogsal

pablogsal commented Jan 8, 2024

Copy link
Copy Markdown
Member Author

Hey @lysnikolaou, can you check if this is more or less what you had in mind? (I will rebase soon)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pythongh-99180: Remove traceback anchors in return and assign stateme…
343a058 
…nts that cover all the displayed range

Signed-off-by: Pablo Galindo <[email protected]>

Apply suggestions from code review

Co-authored-by: Alex Waygood <[email protected]>

fix whitespace issue causing the lint check to fail
@pablogsal
pablogsal force-pushed the gh-99180 branch from 5066492 to 343a058 Compare January 8, 2024 15:38
lysnikolaou
lysnikolaou approved these changes Jan 9, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot like what I had in mind and seeing the implementation I think it's a step towards the right direction!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 9, 2024
@lysnikolaou

lysnikolaou commented Feb 26, 2024

Copy link
Copy Markdown
Member

@pablogsal Let's merge this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 4a08a75 into python:main May 1, 2024
@pablogsal
pablogsal deleted the gh-99180 branch May 1, 2024 13:42
@bedevere-app bedevere-app Bot removed the awaiting merge label May 1, 2024
@pablogsal pablogsal added the needs backport to 3.12 only security fixes label May 1, 2024
@miss-islington-app miss-islington-app Bot assigned pablogsal May 1, 2024
@pablogsal pablogsal removed the needs backport to 3.12 only security fixes label May 1, 2024
@python python deleted a comment from miss-islington-app Bot May 1, 2024
@python python deleted a comment from miss-islington-app Bot May 1, 2024
@bedevere-bot

bedevere-bot commented May 1, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit 4a08a75.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1380/builds/143) and take a look at the build logs.
  4. Check if the failure is related to this commit (4a08a75) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1380/builds/143

Failed tests:

  • test_socket

Failed subtests:

  • test_dual_stack_client_v6 - test.test_socket.CreateServerFunctionalTest.test_dual_stack_client_v6

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/358FF9CB-4D5D-4034-8AFB-6FDD92A7A50B/data/Containers/Bundle/Application/1CB439A9-DD6A-4243-BF2F-EC7DA3A99532/iOSTestbed.app/python/lib/python3.13/test/test_socket.py", line 6847, in test_dual_stack_client_v6
    with socket.create_server(("", port), family=socket.AF_INET6,
         ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                              dualstack_ipv6=True) as sock:
                              ^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/358FF9CB-4D5D-4034-8AFB-6FDD92A7A50B/data/Containers/Bundle/Application/1CB439A9-DD6A-4243-BF2F-EC7DA3A99532/iOSTestbed.app/python/lib/python3.13/socket.py", line 934, in create_server
    raise error(err.errno, msg) from None
OSError: [Errno 48] Address already in use (while attempting to bind on address ('', 57463))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@pablogsal @SonicField
pythongh-99180: Remove traceback anchors in return and assign stateme…
5460446 
…nts that cover all the displayed range (python#112670)
AlexWaygood
AlexWaygood reviewed May 24, 2024
View reviewed changes
Comment thread Lib/traceback.py

return ''.join(row)

def should_show_carets(self, start_offset, end_offset, all_lines, anchors):

@AlexWaygood AlexWaygood May 24, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method meant to be a public-API method on StackSummary objects, or is it meant to be private API? If the former, we should probably document it at https://docs.python.org/3.13/library/traceback.html#stacksummary-objects. If the latter, maybe it should have a name prefixed with an underscore?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal May 24, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be private so I am fine prefixing it with an underscore

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@AlexWaygood AlexWaygood May 25, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#119554

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@lysnikolaou lysnikolaou lysnikolaou approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @lysnikolaou @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.